diff options
author | drh <> | 2023-07-06 20:34:06 +0000 |
---|---|---|
committer | drh <> | 2023-07-06 20:34:06 +0000 |
commit | 7d0103bb06db9d9e4debd61b6da2b2af6f86250b (patch) | |
tree | 7107cb630ecde99518f794335445c3317548353d /src | |
parent | 68c88ea04fff77e8097c8a67db6b61b9ccab5b6f (diff) | |
download | sqlite-7d0103bb06db9d9e4debd61b6da2b2af6f86250b.tar.gz sqlite-7d0103bb06db9d9e4debd61b6da2b2af6f86250b.zip |
Improved handling of integer inputs to the new sum() implementation.
FossilOrigin-Name: 31561c63bde6af2210296810fd66232b935033b4d26273a6b8a52142c54b4e12
Diffstat (limited to 'src')
-rw-r--r-- | src/func.c | 23 |
1 files changed, 16 insertions, 7 deletions
diff --git a/src/func.c b/src/func.c index beafb5431..d6f3d175f 100644 --- a/src/func.c +++ b/src/func.c @@ -1704,11 +1704,14 @@ static void kahanBabuskaNeumaierStep( ** Add a (possibly large) integer to the running sum. */ static void kahanBabuskaNeumaierStepInt64(volatile SumCtx *pSum, i64 iVal){ - volatile double rVal = (double)iVal; - kahanBabuskaNeumaierStep(pSum, rVal); if( iVal<=-4503599627370496 || iVal>=+4503599627370496 ){ - double rDiff = (double)(iVal - (i64)rVal); - kahanBabuskaNeumaierStep(pSum, rDiff); + i64 iBig, iSm; + iSm = iVal % 16384; + iBig = iVal - iSm; + kahanBabuskaNeumaierStep(pSum, iBig); + kahanBabuskaNeumaierStep(pSum, iSm); + }else{ + kahanBabuskaNeumaierStep(pSum, (double)iVal); } } @@ -1716,11 +1719,17 @@ static void kahanBabuskaNeumaierStepInt64(volatile SumCtx *pSum, i64 iVal){ ** Initialize the Kahan-Babaska-Neumaier sum from a 64-bit integer */ static void kahanBabuskaNeumaierInit( - volatile SumCtx *pSum, + volatile SumCtx *p, i64 iVal ){ - pSum->rSum = (double)iVal; - pSum->rErr = (double)(iVal - (i64)pSum->rSum); + if( iVal<=-4503599627370496 || iVal>=+4503599627370496 ){ + i64 iSm = iVal % 16384; + p->rSum = (double)(iVal - iSm); + p->rErr = (double)iSm; + }else{ + p->rSum = (double)iVal; + p->rErr = 0.0; + } } /* |