diff options
author | drh <> | 2025-02-17 17:33:14 +0000 |
---|---|---|
committer | drh <> | 2025-02-17 17:33:14 +0000 |
commit | ef86b942b9ffbfc2086da7865effea3e7950c7a0 (patch) | |
tree | 0eac3b56e88b0a79b7055a0627015c21883d7442 /src/vdbeapi.c | |
parent | ad5dcff53bfb93d0e2ce8165fc2d63f83edd4c79 (diff) | |
download | sqlite-ef86b942b9ffbfc2086da7865effea3e7950c7a0.tar.gz sqlite-ef86b942b9ffbfc2086da7865effea3e7950c7a0.zip |
Code changes that make it easier to prove that no 32-bit integer overflows
happen during memory allocation. No problems fixed; this change is just
to make future maintenance easier.
FossilOrigin-Name: 215650a5a1d55bdbca9c92524804a1a54456a17f42a17e53747b21a6507506f5
Diffstat (limited to 'src/vdbeapi.c')
-rw-r--r-- | src/vdbeapi.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/vdbeapi.c b/src/vdbeapi.c index 0dc09d501..31880d85b 100644 --- a/src/vdbeapi.c +++ b/src/vdbeapi.c @@ -2233,7 +2233,9 @@ int sqlite3_preupdate_old(sqlite3 *db, int iIdx, sqlite3_value **ppValue){ Column *pCol = &p->pTab->aCol[iIdx]; if( pCol->iDflt>0 ){ if( p->apDflt==0 ){ - int nByte = sizeof(sqlite3_value*)*p->pTab->nCol; + int nByte; + assert( sizeof(sqlite3_value*)*UMXV(p->pTab->nCol) < 0x7fffffff ); + nByte = sizeof(sqlite3_value*)*p->pTab->nCol; p->apDflt = (sqlite3_value**)sqlite3DbMallocZero(db, nByte); if( p->apDflt==0 ) goto preupdate_old_out; } @@ -2383,7 +2385,8 @@ int sqlite3_preupdate_new(sqlite3 *db, int iIdx, sqlite3_value **ppValue){ */ assert( p->op==SQLITE_UPDATE ); if( !p->aNew ){ - p->aNew = (Mem *)sqlite3DbMallocZero(db, sizeof(Mem) * p->pCsr->nField); + assert( sizeof(Mem)*UMXV(p->pCsr->nField) < 0x7fffffff ); + p->aNew = (Mem *)sqlite3DbMallocZero(db, sizeof(Mem)*p->pCsr->nField); if( !p->aNew ){ rc = SQLITE_NOMEM; goto preupdate_new_out; |