diff options
author | drh <drh@noemail.net> | 2018-08-04 17:15:56 +0000 |
---|---|---|
committer | drh <drh@noemail.net> | 2018-08-04 17:15:56 +0000 |
commit | 36a5d88ddeeef353f4e24cfa0a37fdae78600c4c (patch) | |
tree | e9c3dfc5162ad87bfcc9c770d3c67b424bf6f267 /src/select.c | |
parent | c6ed275fcb7df895811f37f5f25fe4813cb07c89 (diff) | |
download | sqlite-36a5d88ddeeef353f4e24cfa0a37fdae78600c4c.tar.gz sqlite-36a5d88ddeeef353f4e24cfa0a37fdae78600c4c.zip |
Fix comments that were made obsolete by the removal of the column cache.
FossilOrigin-Name: 2041231d56c7b02b785015ef4d1af260d61326eab1b2a304c17faa3e33f76441
Diffstat (limited to 'src/select.c')
-rw-r--r-- | src/select.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/select.c b/src/select.c index c4ab18d2f..f97efa7a7 100644 --- a/src/select.c +++ b/src/select.c @@ -5334,17 +5334,6 @@ static void updateAccumulator(Parse *pParse, int regAcc, AggInfo *pAggInfo){ sqlite3VdbeResolveLabel(v, addrNext); } } - - /* Before populating the accumulator registers, clear the column cache. - ** Otherwise, if any of the required column values are already present - ** in registers, sqlite3ExprCode() may use OP_SCopy to copy the value - ** to pC->iMem. But by the time the value is used, the original register - ** may have been used, invalidating the underlying buffer holding the - ** text or blob value. See ticket [883034dcb5]. - ** - ** Another solution would be to change the OP_SCopy used to copy cached - ** values to an OP_Copy. - */ if( regHit==0 && pAggInfo->nAccumulator ){ regHit = regAcc; } |