diff options
| author | drh <drh@noemail.net> | 2015-08-24 20:54:06 +0000 |
|---|---|---|
| committer | drh <drh@noemail.net> | 2015-08-24 20:54:06 +0000 |
| commit | fea870be3888ba79a03886205c7a2ba7763177f3 (patch) | |
| tree | 96ae8c84563212839656cc0d30ea7c83a23e1ad9 /src/insert.c | |
| parent | 108aa00a87e19312fa04b9cbaf98c8587128ab86 (diff) | |
| download | sqlite-fea870be3888ba79a03886205c7a2ba7763177f3.tar.gz sqlite-fea870be3888ba79a03886205c7a2ba7763177f3.zip | |
Remove some redundant code: Call sqlite3ResolveExprListNames() rather than
calling sqlite3ResolveExprNames() in a loop - in two places.
FossilOrigin-Name: bdaf66465b6b1bdad10c08d9527b98e7000a41e4
Diffstat (limited to 'src/insert.c')
| -rw-r--r-- | src/insert.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/insert.c b/src/insert.c index 05d84df84..839599438 100644 --- a/src/insert.c +++ b/src/insert.c @@ -705,11 +705,13 @@ void sqlite3Insert( sNC.pParse = pParse; srcTab = -1; assert( useTempTable==0 ); - nColumn = pList ? pList->nExpr : 0; - for(i=0; i<nColumn; i++){ - if( sqlite3ResolveExprNames(&sNC, pList->a[i].pExpr) ){ + if( pList ){ + nColumn = pList->nExpr; + if( sqlite3ResolveExprListNames(&sNC, pList) ){ goto insert_cleanup; } + }else{ + nColumn = 0; } } |