diff options
| author | stephan <stephan@noemail.net> | 2023-04-24 04:25:42 +0000 |
|---|---|---|
| committer | stephan <stephan@noemail.net> | 2023-04-24 04:25:42 +0000 |
| commit | 92df71a360484ba99695cf9b4b7d77459ab741fc (patch) | |
| tree | 7bdc5553ef49a410c4239a4f5fe0b59624e8545d /ext/wasm/api/sqlite3-vfs-opfs.c-pp.js | |
| parent | 022a0428970c8f25b84d465592a2cc243a610da4 (diff) | |
| download | sqlite-92df71a360484ba99695cf9b4b7d77459ab741fc.tar.gz sqlite-92df71a360484ba99695cf9b4b7d77459ab741fc.zip | |
Add a note about the journaling mode in the OPFS VFS. No code changes.
FossilOrigin-Name: e79c95fc130fc302719690eb6391d96070aff825b2b51ef6c4ad459d9a8918d7
Diffstat (limited to 'ext/wasm/api/sqlite3-vfs-opfs.c-pp.js')
| -rw-r--r-- | ext/wasm/api/sqlite3-vfs-opfs.c-pp.js | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/ext/wasm/api/sqlite3-vfs-opfs.c-pp.js b/ext/wasm/api/sqlite3-vfs-opfs.c-pp.js index 2e09aab21..13747ffec 100644 --- a/ext/wasm/api/sqlite3-vfs-opfs.c-pp.js +++ b/ext/wasm/api/sqlite3-vfs-opfs.c-pp.js @@ -1189,7 +1189,15 @@ const installOpfsVfs = function callee(options){ /* Truncate journal mode is faster than delete for this vfs, per speedtest1. That gap seems to have closed with Chrome version 108 or 109, but "persist" is very roughly 5-6% - faster than truncate in initial tests. */ + faster than truncate in initial tests. + + For later analysis: Roy Hashimoto notes that TRUNCATE + and PERSIST modes may decrease OPFS concurrency because + multiple connections can open the journal file in those + modes: + + https://github.com/rhashimoto/wa-sqlite/issues/68 + */ "pragma journal_mode=persist;", /* This vfs benefits hugely from cache on moderate/large |