aboutsummaryrefslogtreecommitdiff
path: root/ext/wasm/api/sqlite3-api-prologue.js
diff options
context:
space:
mode:
authorstephan <stephan@noemail.net>2022-10-01 12:04:49 +0000
committerstephan <stephan@noemail.net>2022-10-01 12:04:49 +0000
commit6167d5cf17876c7b6cd6b6b0ab789b82d33b41bc (patch)
tree1e67f9aeac6795dcc59eb03e8ff508bc105782cf /ext/wasm/api/sqlite3-api-prologue.js
parent8c1a4b89af13be96c7416f9d2357b1b188580e82 (diff)
downloadsqlite-6167d5cf17876c7b6cd6b6b0ab789b82d33b41bc.tar.gz
sqlite-6167d5cf17876c7b6cd6b6b0ab789b82d33b41bc.zip
Note two wasm-related potential TODOs.
FossilOrigin-Name: 5636e82864457d870754ee7125c307dc5d2195197a5c0266579da9f102938b89
Diffstat (limited to 'ext/wasm/api/sqlite3-api-prologue.js')
-rw-r--r--ext/wasm/api/sqlite3-api-prologue.js12
1 files changed, 10 insertions, 2 deletions
diff --git a/ext/wasm/api/sqlite3-api-prologue.js b/ext/wasm/api/sqlite3-api-prologue.js
index b738485cb..a6e055ff4 100644
--- a/ext/wasm/api/sqlite3-api-prologue.js
+++ b/ext/wasm/api/sqlite3-api-prologue.js
@@ -611,13 +611,21 @@ self.sqlite3ApiBootstrap = function sqlite3ApiBootstrap(
*/
capi.wasm.bindingSignatures = [
// Please keep these sorted by function name!
- ["sqlite3_bind_blob","int", "sqlite3_stmt*", "int", "*", "int", "*"],
+ ["sqlite3_bind_blob","int", "sqlite3_stmt*", "int", "*", "int", "*"
+ /* We should arguably write a custom wrapper which knows how
+ to handle Blob, TypedArrays, and JS strings. */
+ ],
["sqlite3_bind_double","int", "sqlite3_stmt*", "int", "f64"],
["sqlite3_bind_int","int", "sqlite3_stmt*", "int", "int"],
["sqlite3_bind_null",undefined, "sqlite3_stmt*", "int"],
["sqlite3_bind_parameter_count", "int", "sqlite3_stmt*"],
["sqlite3_bind_parameter_index","int", "sqlite3_stmt*", "string"],
- ["sqlite3_bind_text","int", "sqlite3_stmt*", "int", "string", "int", "int"],
+ ["sqlite3_bind_text","int", "sqlite3_stmt*", "int", "string", "int", "int"
+ /* We should arguably create a hand-written binding
+ which does more flexible text conversion, along the lines of
+ sqlite3_prepare_v3(). The slightly problematic part is the
+ final argument (text destructor). */
+ ],
["sqlite3_close_v2", "int", "sqlite3*"],
["sqlite3_changes", "int", "sqlite3*"],
["sqlite3_clear_bindings","int", "sqlite3_stmt*"],