diff options
Diffstat (limited to 'src/backend/executor')
-rw-r--r-- | src/backend/executor/execJunk.c | 23 | ||||
-rw-r--r-- | src/backend/executor/execMain.c | 4 | ||||
-rw-r--r-- | src/backend/executor/execQual.c | 10 | ||||
-rw-r--r-- | src/backend/executor/execTuples.c | 11 | ||||
-rw-r--r-- | src/backend/executor/execUtils.c | 4 | ||||
-rw-r--r-- | src/backend/executor/functions.c | 8 | ||||
-rw-r--r-- | src/backend/executor/nodeSubplan.c | 22 |
7 files changed, 37 insertions, 45 deletions
diff --git a/src/backend/executor/execJunk.c b/src/backend/executor/execJunk.c index 2dfd90b51fa..1cf403f88dd 100644 --- a/src/backend/executor/execJunk.c +++ b/src/backend/executor/execJunk.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execJunk.c,v 1.48 2005/03/16 21:38:06 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execJunk.c,v 1.49 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -31,8 +31,8 @@ * of some system attributes like "ctid" or rule locks. * * The general idea is the following: A target list consists of a list of - * Resdom nodes & expression pairs. Each Resdom node has an attribute - * called 'resjunk'. If the value of this attribute is true then the + * TargetEntry nodes containing expressions. Each TargetEntry has a field + * called 'resjunk'. If the value of this field is true then the * corresponding attribute is a "junk" attribute. * * When we initialize a plan we call 'ExecInitJunkFilter' to create @@ -101,11 +101,10 @@ ExecInitJunkFilter(List *targetList, bool hasoid, TupleTableSlot *slot) foreach(t, targetList) { TargetEntry *tle = lfirst(t); - Resdom *resdom = tle->resdom; - if (!resdom->resjunk) + if (!tle->resjunk) { - cleanMap[cleanResno - 1] = resdom->resno; + cleanMap[cleanResno - 1] = tle->resno; cleanResno++; } } @@ -177,12 +176,11 @@ ExecInitJunkFilterConversion(List *targetList, for (;;) { TargetEntry *tle = lfirst(t); - Resdom *resdom = tle->resdom; t = lnext(t); - if (!resdom->resjunk) + if (!tle->resjunk) { - cleanMap[i] = resdom->resno; + cleanMap[i] = tle->resno; break; } } @@ -228,13 +226,12 @@ ExecGetJunkAttribute(JunkFilter *junkfilter, foreach(t, junkfilter->jf_targetList) { TargetEntry *tle = lfirst(t); - Resdom *resdom = tle->resdom; - if (resdom->resjunk && resdom->resname && - (strcmp(resdom->resname, attrName) == 0)) + if (tle->resjunk && tle->resname && + (strcmp(tle->resname, attrName) == 0)) { /* We found it ! */ - *value = slot_getattr(slot, resdom->resno, isNull); + *value = slot_getattr(slot, tle->resno, isNull); return true; } } diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 304f1ba6b10..0ba61044222 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -26,7 +26,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.244 2005/03/25 21:57:58 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.245 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -640,7 +640,7 @@ InitPlan(QueryDesc *queryDesc, bool explainOnly) { TargetEntry *tle = (TargetEntry *) lfirst(tlist); - if (tle->resdom->resjunk) + if (tle->resjunk) { junk_filter_needed = true; break; diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c index 9d915af91a5..67c962398e8 100644 --- a/src/backend/executor/execQual.c +++ b/src/backend/executor/execQual.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.175 2005/03/29 00:16:59 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.176 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -3467,7 +3467,7 @@ ExecCleanTargetListLength(List *targetlist) TargetEntry *curTle = (TargetEntry *) lfirst(tl); Assert(IsA(curTle, TargetEntry)); - if (!curTle->resdom->resjunk) + if (!curTle->resjunk) len++; } return len; @@ -3516,7 +3516,7 @@ ExecTargetList(List *targetlist, { GenericExprState *gstate = (GenericExprState *) lfirst(tl); TargetEntry *tle = (TargetEntry *) gstate->xprstate.expr; - AttrNumber resind = tle->resdom->resno - 1; + AttrNumber resind = tle->resno - 1; values[resind] = ExecEvalExpr(gstate->arg, econtext, @@ -3568,7 +3568,7 @@ ExecTargetList(List *targetlist, { GenericExprState *gstate = (GenericExprState *) lfirst(tl); TargetEntry *tle = (TargetEntry *) gstate->xprstate.expr; - AttrNumber resind = tle->resdom->resno - 1; + AttrNumber resind = tle->resno - 1; if (itemIsDone[resind] == ExprEndResult) { @@ -3602,7 +3602,7 @@ ExecTargetList(List *targetlist, { GenericExprState *gstate = (GenericExprState *) lfirst(tl); TargetEntry *tle = (TargetEntry *) gstate->xprstate.expr; - AttrNumber resind = tle->resdom->resno - 1; + AttrNumber resind = tle->resno - 1; while (itemIsDone[resind] == ExprMultipleResult) { diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c index 7941cebad6b..1c82a3b64be 100644 --- a/src/backend/executor/execTuples.c +++ b/src/backend/executor/execTuples.c @@ -15,7 +15,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execTuples.c,v 1.86 2005/03/17 15:25:51 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execTuples.c,v 1.87 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -784,15 +784,14 @@ ExecTypeFromTLInternal(List *targetList, bool hasoid, bool skipjunk) foreach(l, targetList) { TargetEntry *tle = lfirst(l); - Resdom *resdom = tle->resdom; - if (skipjunk && resdom->resjunk) + if (skipjunk && tle->resjunk) continue; TupleDescInitEntry(typeInfo, cur_resno++, - resdom->resname, - resdom->restype, - resdom->restypmod, + tle->resname, + exprType((Node *) tle->expr), + exprTypmod((Node *) tle->expr), 0); } diff --git a/src/backend/executor/execUtils.c b/src/backend/executor/execUtils.c index b1840b45cf9..820c0429132 100644 --- a/src/backend/executor/execUtils.c +++ b/src/backend/executor/execUtils.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.119 2005/03/21 01:24:03 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.120 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -561,7 +561,7 @@ ExecBuildProjectionInfo(List *targetList, Var *variable = (Var *) gstate->arg->expr; AttrNumber attnum = variable->varattno; TargetEntry *tle = (TargetEntry *) gstate->xprstate.expr; - AttrNumber resind = tle->resdom->resno - 1; + AttrNumber resind = tle->resno - 1; Assert(resind >= 0 && resind < len); varNumbers[resind] = attnum; diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c index d2e101a2d61..521d656ff16 100644 --- a/src/backend/executor/functions.c +++ b/src/backend/executor/functions.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.95 2005/03/31 22:46:08 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.96 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -935,7 +935,7 @@ check_sql_fn_retval(Oid func_id, Oid rettype, List *queryTreeList, format_type_be(rettype)), errdetail("Final SELECT must return exactly one column."))); - restype = ((TargetEntry *) linitial(tlist))->resdom->restype; + restype = exprType((Node *) ((TargetEntry *) linitial(tlist))->expr); if (!IsBinaryCoercible(restype, rettype)) ereport(ERROR, (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION), @@ -961,7 +961,7 @@ check_sql_fn_retval(Oid func_id, Oid rettype, List *queryTreeList, */ if (tlistlen == 1) { - restype = ((TargetEntry *) linitial(tlist))->resdom->restype; + restype = exprType((Node *) ((TargetEntry *) linitial(tlist))->expr); if (IsBinaryCoercible(restype, rettype)) return false; /* NOT returning whole tuple */ } @@ -996,7 +996,7 @@ check_sql_fn_retval(Oid func_id, Oid rettype, List *queryTreeList, Oid tletype; Oid atttype; - if (tle->resdom->resjunk) + if (tle->resjunk) continue; do diff --git a/src/backend/executor/nodeSubplan.c b/src/backend/executor/nodeSubplan.c index 7d40fe8b1ed..de3187e2472 100644 --- a/src/backend/executor/nodeSubplan.c +++ b/src/backend/executor/nodeSubplan.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/nodeSubplan.c,v 1.67 2005/03/16 21:38:08 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/nodeSubplan.c,v 1.68 2005/04/06 16:34:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -828,12 +828,10 @@ ExecInitSubPlan(SubPlanState *node, EState *estate) /* Process lefthand argument */ exstate = (ExprState *) linitial(fstate->args); expr = exstate->expr; - tle = makeTargetEntry(makeResdom(i, - exprType((Node *) expr), - exprTypmod((Node *) expr), - NULL, - false), - expr); + tle = makeTargetEntry(expr, + i, + NULL, + false); tlestate = makeNode(GenericExprState); tlestate->xprstate.expr = (Expr *) tle; tlestate->xprstate.evalfunc = NULL; @@ -844,12 +842,10 @@ ExecInitSubPlan(SubPlanState *node, EState *estate) /* Process righthand argument */ exstate = (ExprState *) lsecond(fstate->args); expr = exstate->expr; - tle = makeTargetEntry(makeResdom(i, - exprType((Node *) expr), - exprTypmod((Node *) expr), - NULL, - false), - expr); + tle = makeTargetEntry(expr, + i, + NULL, + false); tlestate = makeNode(GenericExprState); tlestate->xprstate.expr = (Expr *) tle; tlestate->xprstate.evalfunc = NULL; |