diff options
Diffstat (limited to 'src/backend/access/spgist/spginsert.c')
-rw-r--r-- | src/backend/access/spgist/spginsert.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/src/backend/access/spgist/spginsert.c b/src/backend/access/spgist/spginsert.c index f4d0fe5a0c2..2a50d87c74b 100644 --- a/src/backend/access/spgist/spginsert.c +++ b/src/backend/access/spgist/spginsert.c @@ -45,10 +45,17 @@ spgistBuildCallback(Relation index, HeapTuple htup, Datum *values, /* Work in temp context, and reset it after each tuple */ oldCtx = MemoryContextSwitchTo(buildstate->tmpCtx); - /* No concurrent insertions can be happening, so failure is unexpected */ - if (!spgdoinsert(index, &buildstate->spgstate, &htup->t_self, - *values, *isnull)) - elog(ERROR, "unexpected spgdoinsert() failure"); + /* + * Even though no concurrent insertions can be happening, we still might + * get a buffer-locking failure due to bgwriter or checkpointer taking a + * lock on some buffer. So we need to be willing to retry. We can flush + * any temp data when retrying. + */ + while (!spgdoinsert(index, &buildstate->spgstate, &htup->t_self, + *values, *isnull)) + { + MemoryContextReset(buildstate->tmpCtx); + } MemoryContextSwitchTo(oldCtx); MemoryContextReset(buildstate->tmpCtx); |