diff options
-rw-r--r-- | src/backend/replication/logical/logicalfuncs.c | 11 | ||||
-rw-r--r-- | src/backend/replication/slot.c | 12 | ||||
-rw-r--r-- | src/backend/replication/slotfuncs.c | 19 | ||||
-rw-r--r-- | src/include/replication/slot.h | 1 |
4 files changed, 19 insertions, 24 deletions
diff --git a/src/backend/replication/logical/logicalfuncs.c b/src/backend/replication/logical/logicalfuncs.c index 1f38c5b33ea..e59939aad11 100644 --- a/src/backend/replication/logical/logicalfuncs.c +++ b/src/backend/replication/logical/logicalfuncs.c @@ -95,15 +95,6 @@ LogicalOutputWrite(LogicalDecodingContext *ctx, XLogRecPtr lsn, TransactionId xi p->returned_rows++; } -static void -check_permissions(void) -{ - if (!superuser() && !has_rolreplication(GetUserId())) - ereport(ERROR, - (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), - errmsg("must be superuser or replication role to use replication slots"))); -} - /* * Helper function for the various SQL callable logical decoding functions. */ @@ -124,7 +115,7 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo fcinfo, bool confirm, bool bin List *options = NIL; DecodingOutputState *p; - check_permissions(); + CheckSlotPermissions(); CheckLogicalDecodingRequirements(); diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c index 33e9acab4a8..1c6c0c7ce27 100644 --- a/src/backend/replication/slot.c +++ b/src/backend/replication/slot.c @@ -1060,6 +1060,18 @@ CheckSlotRequirements(void) } /* + * Check whether the user has privilege to use replication slots. + */ +void +CheckSlotPermissions(void) +{ + if (!superuser() && !has_rolreplication(GetUserId())) + ereport(ERROR, + (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), + errmsg("must be superuser or replication role to use replication slots"))); +} + +/* * Reserve WAL for the currently active slot. * * Compute and set restart_lsn in a manner that's appropriate for the type of diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c index 31e74d38322..17df99c2ace 100644 --- a/src/backend/replication/slotfuncs.c +++ b/src/backend/replication/slotfuncs.c @@ -25,15 +25,6 @@ #include "utils/pg_lsn.h" #include "utils/resowner.h" -static void -check_permissions(void) -{ - if (!superuser() && !has_rolreplication(GetUserId())) - ereport(ERROR, - (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), - errmsg("must be superuser or replication role to use replication slots"))); -} - /* * Helper function for creating a new physical replication slot with * given arguments. Note that this function doesn't release the created @@ -85,7 +76,7 @@ pg_create_physical_replication_slot(PG_FUNCTION_ARGS) if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE) elog(ERROR, "return type must be a row type"); - check_permissions(); + CheckSlotPermissions(); CheckSlotRequirements(); @@ -188,7 +179,7 @@ pg_create_logical_replication_slot(PG_FUNCTION_ARGS) if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE) elog(ERROR, "return type must be a row type"); - check_permissions(); + CheckSlotPermissions(); CheckLogicalDecodingRequirements(); @@ -224,7 +215,7 @@ pg_drop_replication_slot(PG_FUNCTION_ARGS) { Name name = PG_GETARG_NAME(0); - check_permissions(); + CheckSlotPermissions(); CheckSlotRequirements(); @@ -619,7 +610,7 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS) Assert(!MyReplicationSlot); - check_permissions(); + CheckSlotPermissions(); if (XLogRecPtrIsInvalid(moveto)) ereport(ERROR, @@ -718,7 +709,7 @@ copy_replication_slot(FunctionCallInfo fcinfo, bool logical_slot) if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE) elog(ERROR, "return type must be a row type"); - check_permissions(); + CheckSlotPermissions(); if (logical_slot) CheckLogicalDecodingRequirements(); diff --git a/src/include/replication/slot.h b/src/include/replication/slot.h index e32fb85db8e..53d773ccffe 100644 --- a/src/include/replication/slot.h +++ b/src/include/replication/slot.h @@ -222,5 +222,6 @@ extern void StartupReplicationSlots(void); extern void CheckPointReplicationSlots(void); extern void CheckSlotRequirements(void); +extern void CheckSlotPermissions(void); #endif /* SLOT_H */ |