diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2021-10-04 14:32:21 +0200 |
|---|---|---|
| committer | Daniel Gustafsson <dgustafsson@postgresql.org> | 2021-10-04 14:32:21 +0200 |
| commit | e9bc0441f1446f6614fa6712841acec91890e089 (patch) | |
| tree | 6d18253de109d3f23a554d0a124daa451e84db0c /src | |
| parent | ce27c8953e8e48c69c690c0e5795cde40ed59fd2 (diff) | |
| download | postgresql-e9bc0441f1446f6614fa6712841acec91890e089.tar.gz postgresql-e9bc0441f1446f6614fa6712841acec91890e089.zip | |
Provide error hint on exit() check when building libpq
Commit dc227eb82 introduced a restriction on libpq that no functions which
invoke exit() are allowed to be called. This was further refined and fixed
in e45b0dfa1f and 2f7bae2f92 and 792259591. While this is well documented
in the Makefile, the error message emitted when the check failed was terse,
without hints for new developers without prior context. This adds an error
hint to assist new developers onboarding to postgres.
Author: Rachel Heaton <rheaton@vmware.com>
Co-authored-by: Jacob Champion <pchampion@vmware.com>
Discussion: https://postgr.es/m/CADJcwiVL20955HCNzDqz9BEDr6A77pz6-nac5sbZVvhAEMijLg@mail.gmail.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/interfaces/libpq/Makefile | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile index 7cbdeb589bd..d98bc071439 100644 --- a/src/interfaces/libpq/Makefile +++ b/src/interfaces/libpq/Makefile @@ -115,7 +115,9 @@ backend_src = $(top_srcdir)/src/backend libpq-refs-stamp: $(shlib) ifneq ($(enable_coverage), yes) ifeq (,$(filter aix solaris,$(PORTNAME))) - ! nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit + @if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \ + echo 'libpq must not be calling any function which invokes exit'; exit 1; \ + fi endif endif touch $@ |