aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2022-01-23 13:54:24 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2022-01-23 13:54:24 -0500
commitac7df108cf32e11e4bd120898ed09bd58fa5b62c (patch)
treef1be459ce45bdd57e25a71f874906f81317d3b0f /src
parent353708e1fb2d8b1a34f6da2c25d4bb6633cf4493 (diff)
downloadpostgresql-ac7df108cf32e11e4bd120898ed09bd58fa5b62c.tar.gz
postgresql-ac7df108cf32e11e4bd120898ed09bd58fa5b62c.zip
pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid
Commit 6df7a9698 wrote appendPQExpBuffer where it should have written printfPQExpBuffer. This resulted in re-issuing the previous query along with the desired one, which very accidentally had no negative consequences except for some wasted cycles. Back-patch to v14 where that came in. Discussion: https://postgr.es/m/1714711.1642962663@sss.pgh.pa.us
Diffstat (limited to 'src')
-rw-r--r--src/bin/pg_dump/pg_dump.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 7c0e396ce13..f1e8b0b5c2c 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -4574,7 +4574,7 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout,
{
if (fout->remoteVersion >= 140000)
{
- appendPQExpBuffer(upgrade_query,
+ printfPQExpBuffer(upgrade_query,
"SELECT t.oid, t.typarray "
"FROM pg_catalog.pg_type t "
"JOIN pg_catalog.pg_range r "