diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-03-31 17:14:16 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-03-31 17:14:16 -0400 |
| commit | 9e20406dd847d0f8c1cbd803786c6d0ad33bcbdd (patch) | |
| tree | 4334584605784f30ca096c1ef05a72d7409a5b40 /src | |
| parent | f1be740a991406d7885047beb971e1ff5dbe8b71 (diff) | |
| download | postgresql-9e20406dd847d0f8c1cbd803786c6d0ad33bcbdd.tar.gz postgresql-9e20406dd847d0f8c1cbd803786c6d0ad33bcbdd.zip | |
Fix unportable use of isprint().
We must cast the arguments of <ctype.h> functions to unsigned
char to avoid problems where char is signed.
Speaking of which, considering that this *is* a <ctype.h> function,
it's rather remarkable that we aren't seeing more complaints about
not having included that header.
Per buildfarm.
Diffstat (limited to 'src')
| -rw-r--r-- | src/interfaces/libpq/fe-trace.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/interfaces/libpq/fe-trace.c b/src/interfaces/libpq/fe-trace.c index 5faeee74519..ca59c183182 100644 --- a/src/interfaces/libpq/fe-trace.c +++ b/src/interfaces/libpq/fe-trace.c @@ -14,6 +14,7 @@ #include "postgres_fe.h" +#include <ctype.h> #include <limits.h> #include <time.h> @@ -28,6 +29,7 @@ #include "libpq-int.h" #include "port/pg_bswap.h" + /* Enable tracing */ void PQtrace(PGconn *conn, FILE *debug_port) @@ -102,7 +104,7 @@ pqTraceOutputByte1(FILE *pfdebug, const char *data, int *cursor) * Show non-printable data in hex format, including the terminating \0 * that completes ErrorResponse and NoticeResponse messages. */ - if (!isprint(*v)) + if (!isprint((unsigned char) *v)) fprintf(pfdebug, " \\x%02x", *v); else fprintf(pfdebug, " %c", *v); @@ -186,7 +188,7 @@ pqTraceOutputNchar(FILE *pfdebug, int len, const char *data, int *cursor) for (next = i = 0; i < len; ++i) { - if (isprint(v[i])) + if (isprint((unsigned char) v[i])) continue; else { |