diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2021-04-01 16:12:53 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2021-04-01 16:12:53 +0200 |
| commit | 91e7c903291116bd081abe7d4a058d40a2a06e16 (patch) | |
| tree | 64d8c9848e98ffc978064616820f0def79b6cef9 /src | |
| parent | dde1a35aee6266dc8105717275335c46cd2b3650 (diff) | |
| download | postgresql-91e7c903291116bd081abe7d4a058d40a2a06e16.tar.gz postgresql-91e7c903291116bd081abe7d4a058d40a2a06e16.zip | |
Fix internal extract(timezone_minute) formulas
Through various refactorings over time, the extract(timezone_minute
from time with time zone) and extract(timezone_minute from timestamp
with time zone) implementations ended up with two different but
equally nonsensical formulas by using SECS_PER_MINUTE and
MINS_PER_HOUR interchangeably. Since those two are of course both the
same number, the formulas do work, but for readability, fix them to be
semantically correct.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/utils/adt/date.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/adt/timestamp.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/date.c b/src/backend/utils/adt/date.c index 68d99a50992..6053d0e8a6f 100644 --- a/src/backend/utils/adt/date.c +++ b/src/backend/utils/adt/date.c @@ -2726,7 +2726,7 @@ timetz_part(PG_FUNCTION_ARGS) case DTK_TZ_MINUTE: result = -tz; result /= SECS_PER_MINUTE; - FMODULO(result, dummy, (double) SECS_PER_MINUTE); + FMODULO(result, dummy, (double) MINS_PER_HOUR); break; case DTK_TZ_HOUR: diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c index f619b56d6f5..194861f19e3 100644 --- a/src/backend/utils/adt/timestamp.c +++ b/src/backend/utils/adt/timestamp.c @@ -4844,7 +4844,7 @@ timestamptz_part(PG_FUNCTION_ARGS) case DTK_TZ_MINUTE: result = -tz; - result /= MINS_PER_HOUR; + result /= SECS_PER_MINUTE; FMODULO(result, dummy, (double) MINS_PER_HOUR); break; |