diff options
| author | Andres Freund <andres@anarazel.de> | 2021-02-15 17:12:12 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2021-02-15 17:12:12 -0800 |
| commit | 8001cb77ee6cb4f32632850d41f00206a86bac3e (patch) | |
| tree | 01bb308b8e552783f81b06b9f16061147d621863 /src | |
| parent | a975ff4980d60f8cbd8d8cbcff70182ea53e787a (diff) | |
| download | postgresql-8001cb77ee6cb4f32632850d41f00206a86bac3e.tar.gz postgresql-8001cb77ee6cb4f32632850d41f00206a86bac3e.zip | |
Fix heap_page_prune() parameter order confusion introduced in dc7420c2c92.
Both luckily and unluckily the passed values meant the same for all
types. Luckily because that meant my confusion caused no harm,
unluckily because otherwise the compiler might have warned...
In passing, synchronize parameter names between definition and
declaration.
Reported-By: Peter Geoghegan <pg@bowt.ie>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CAH2-Wz=L=nBoepQdH9b5Qd0nMvepFT2CnT6sjWvvpOXa=K8HVQ@mail.gmail.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/access/heap/vacuumlazy.c | 4 | ||||
| -rw-r--r-- | src/include/access/heapam.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index e9bd6dba80f..0bb78162f54 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -1237,8 +1237,8 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats, * We count tuples removed by the pruning step as removed by VACUUM * (existing LP_DEAD line pointers don't count). */ - tups_vacuumed += heap_page_prune(onerel, buf, vistest, false, - InvalidTransactionId, 0, + tups_vacuumed += heap_page_prune(onerel, buf, vistest, + InvalidTransactionId, 0, false, &vacrelstats->latestRemovedXid, &vacrelstats->offnum); diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h index d96a47b1cec..60e5cd3109b 100644 --- a/src/include/access/heapam.h +++ b/src/include/access/heapam.h @@ -174,8 +174,8 @@ struct GlobalVisState; extern void heap_page_prune_opt(Relation relation, Buffer buffer); extern int heap_page_prune(Relation relation, Buffer buffer, struct GlobalVisState *vistest, - TransactionId limited_oldest_xmin, - TimestampTz limited_oldest_ts, + TransactionId old_snap_xmin, + TimestampTz old_snap_ts_ts, bool report_stats, TransactionId *latestRemovedXid, OffsetNumber *off_loc); extern void heap_page_prune_execute(Buffer buffer, |