aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2024-10-17 08:36:14 +0200
committerPeter Eisentraut <peter@eisentraut.org>2024-10-17 08:36:48 +0200
commit665785d85f8b9a7250802d7fadd84841bb0aafa1 (patch)
treef4e891efd3f1a4a63f2ab6d727c1a32ebe115984 /src
parenteafda78fc404c706da4cfa254dafb3e97f6cd111 (diff)
downloadpostgresql-665785d85f8b9a7250802d7fadd84841bb0aafa1.tar.gz
postgresql-665785d85f8b9a7250802d7fadd84841bb0aafa1.zip
Fix unnecessary casts of copyObject() result
The result is already of the correct type, so these casts don't do anything. Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Tender Wang <tndrwang@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/637eeea8-5663-460b-a114-39572c0f6c6e%40eisentraut.org
Diffstat (limited to 'src')
-rw-r--r--src/backend/commands/trigger.c2
-rw-r--r--src/backend/nodes/nodeFuncs.c4
-rw-r--r--src/backend/rewrite/rewriteManip.c2
3 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
index 3671e82535e..09356e46d16 100644
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -1169,7 +1169,7 @@ CreateTriggerFiringOn(CreateTrigStmt *stmt, const char *queryString,
* Initialize our fabricated parse node by copying the original
* one, then resetting fields that we pass separately.
*/
- childStmt = (CreateTrigStmt *) copyObject(stmt);
+ childStmt = copyObject(stmt);
childStmt->funcname = NIL;
childStmt->whenClause = NULL;
diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 0d00e029f32..f76072228c9 100644
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -2996,7 +2996,7 @@ expression_tree_mutator_impl(Node *node,
case T_SortGroupClause:
case T_CTESearchClause:
case T_MergeSupportFunc:
- return (Node *) copyObject(node);
+ return copyObject(node);
case T_WithCheckOption:
{
WithCheckOption *wco = (WithCheckOption *) node;
@@ -3604,7 +3604,7 @@ expression_tree_mutator_impl(Node *node,
break;
case T_PartitionPruneStepCombine:
/* no expression sub-nodes */
- return (Node *) copyObject(node);
+ return copyObject(node);
case T_JoinExpr:
{
JoinExpr *join = (JoinExpr *) node;
diff --git a/src/backend/rewrite/rewriteManip.c b/src/backend/rewrite/rewriteManip.c
index b20625fbd2b..8f90afb3269 100644
--- a/src/backend/rewrite/rewriteManip.c
+++ b/src/backend/rewrite/rewriteManip.c
@@ -1715,7 +1715,7 @@ ReplaceVarsFromTargetList_callback(Var *var,
break;
case REPLACEVARS_CHANGE_VARNO:
- var = (Var *) copyObject(var);
+ var = copyObject(var);
var->varno = rcon->nomatch_varno;
/* we leave the syntactic referent alone */
return (Node *) var;