aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2024-06-30 17:33:06 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2024-06-30 17:33:32 -0400
commit54508209178bc73a497c460bd0ffd1645dceb1a2 (patch)
tree369e32b93dac306ab1d2b2d44a318a415fe0981a /src
parent35a7b288b975f8b13084307c4b610e3bed5ca046 (diff)
downloadpostgresql-54508209178bc73a497c460bd0ffd1645dceb1a2.tar.gz
postgresql-54508209178bc73a497c460bd0ffd1645dceb1a2.zip
Temporarily(?) weaken new pg_createsubscriber test on Windows.
Don't include double-quotes (") in the generated database names on Windows. Doing so tickles a bug in older versions of IPC::Run, which fail to quote command line arguments correctly for that platform. Possibly we can revert this after updating affected buildfarm animals. Discussion: https://postgr.es/m/2509767.1719773880@sss.pgh.pa.us
Diffstat (limited to 'src')
-rw-r--r--src/bin/pg_basebackup/t/040_pg_createsubscriber.pl4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
index 68b798333d1..9e2d838503e 100644
--- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
+++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
@@ -29,6 +29,10 @@ sub generate_db
}
$dbname .= $suffix;
+
+ # Old IPC::Run mis-quotes command line arguments containing '"' on Windows
+ $dbname =~ tr/\"//d if ($windows_os);
+
$node->command_ok(
[ 'createdb', $dbname ],
"created database with ASCII characters from $from_char to $to_char");