diff options
| author | Bruce Momjian <bruce@momjian.us> | 2002-10-14 18:11:17 +0000 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2002-10-14 18:11:17 +0000 |
| commit | 4a513ab07f9676dc4554b5cb20c60e1ed19aa903 (patch) | |
| tree | cf41bc92ee73d5dd8c8336cd5971e923cf548b0e /src | |
| parent | 6d9d97e8ab638c05ac617c625a17a7ace7f92f41 (diff) | |
| download | postgresql-4a513ab07f9676dc4554b5cb20c60e1ed19aa903.tar.gz postgresql-4a513ab07f9676dc4554b5cb20c60e1ed19aa903.zip | |
Mention that resetting the timeout may be wrong on select retry.
Diffstat (limited to 'src')
| -rw-r--r-- | src/interfaces/libpq/fe-misc.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c index 32b197bf6b6..7b5a2eeb152 100644 --- a/src/interfaces/libpq/fe-misc.c +++ b/src/interfaces/libpq/fe-misc.c @@ -25,7 +25,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.82 2002/10/14 17:33:08 momjian Exp $ + * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.83 2002/10/14 18:11:17 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -824,7 +824,12 @@ retry5: { /* * select() may modify timeout argument on some platforms so - * use copy + * use copy. + * XXX Do we really want to do that? If select() returns + * the number of seconds remaining, we are resetting + * the timeout to its original value. This will yeild + * incorrect timings when select() is interrupted. + * bjm 2002-10-14 */ tmp_timeout = *timeout; ptmp_timeout = &tmp_timeout; |