aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-09-20 11:28:34 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-09-20 11:28:34 -0400
commit4939488af9b86edfff9b981773cd388d361c5830 (patch)
treeb2ae05f6bd5e148ff497d0213073777f19b07fe4 /src
parent36b564c648a044e42ca461466ae14d8588e6c5e2 (diff)
downloadpostgresql-4939488af9b86edfff9b981773cd388d361c5830.tar.gz
postgresql-4939488af9b86edfff9b981773cd388d361c5830.zip
Fix instability in subscription regression test.
005_encoding.pl neglected to wait for the subscriber's initial synchronization to happen. While we have not seen this fail in the buildfarm, it's pretty easy to demonstrate there's an issue by hacking logicalrep_worker_launch() to fail most of the time. Michael Paquier Discussion: https://postgr.es/m/27032.1505749806@sss.pgh.pa.us
Diffstat (limited to 'src')
-rw-r--r--src/test/subscription/t/005_encoding.pl6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/test/subscription/t/005_encoding.pl b/src/test/subscription/t/005_encoding.pl
index 26a40c0b7f1..2b0c47c07d3 100644
--- a/src/test/subscription/t/005_encoding.pl
+++ b/src/test/subscription/t/005_encoding.pl
@@ -41,6 +41,12 @@ $node_subscriber->safe_psql('postgres',
wait_for_caught_up($node_publisher, $appname);
+# Wait for initial sync to finish as well
+my $synced_query =
+ "SELECT count(1) = 0 FROM pg_subscription_rel WHERE srsubstate NOT IN ('s', 'r');";
+$node_subscriber->poll_query_until('postgres', $synced_query)
+ or die "Timed out while waiting for subscriber to synchronize data";
+
$node_publisher->safe_psql('postgres',
q{INSERT INTO test1 VALUES (1, E'Mot\xc3\xb6rhead')}); # hand-rolled UTF-8