diff options
| author | Michael Paquier <michael@paquier.xyz> | 2019-10-08 13:59:53 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2019-10-08 13:59:53 +0900 |
| commit | 491bb81fb803b0477062bb0a51edb752fa2cb396 (patch) | |
| tree | baf046b71673134b9988f83860ae65883b6767b2 /src | |
| parent | 55ba56415bae6ac1f43c12d54537bd60eaa2153b (diff) | |
| download | postgresql-491bb81fb803b0477062bb0a51edb752fa2cb396.tar.gz postgresql-491bb81fb803b0477062bb0a51edb752fa2cb396.zip | |
Clarify some comments about ntstatus.h in win32_port.h
Some comments in this file referred to outdated links. This simplifies
the outdated comment blocks and refreshes the links.
Reported-by: Vignesh C
Author: Juan José SantamarÃa Flecha
Discussion: https://postgr.es/m/46C03E17-16F7-4C38-B148-029AC7448E96@gmail.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/port/win32_port.h | 25 |
1 files changed, 8 insertions, 17 deletions
diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h index 1cf166a570d..4b935178e12 100644 --- a/src/include/port/win32_port.h +++ b/src/include/port/win32_port.h @@ -103,11 +103,11 @@ * For WIN32, there is no wait() call so there are no wait() macros * to interpret the return value of system(). Instead, system() * return values < 0x100 are used for exit() termination, and higher - * values are used to indicated non-exit() termination, which is + * values are used to indicate non-exit() termination, which is * similar to a unix-style signal exit (think SIGSEGV == * STATUS_ACCESS_VIOLATION). Return values are broken up into groups: * - * http://msdn2.microsoft.com/en-gb/library/aa489609.aspx + * https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/using-ntstatus-values * * NT_SUCCESS 0 - 0x3FFFFFFF * NT_INFORMATION 0x40000000 - 0x7FFFFFFF @@ -121,22 +121,13 @@ * * Wine (URL used in our error messages) - * http://source.winehq.org/source/include/ntstatus.h - * Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt - * MS SDK - http://www.nologs.com/ntstatus.html + * Descriptions - + * https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55 * - * It seems the exception lists are in both ntstatus.h and winnt.h, but - * ntstatus.h has a more comprehensive list, and it only contains - * exception values, rather than winnt, which contains lots of other - * things: - * - * http://www.microsoft.com/msj/0197/exception/exception.aspx - * - * The ExceptionCode parameter is the number that the operating system - * assigned to the exception. You can see a list of various exception codes - * in WINNT.H by searching for #defines that start with "STATUS_". For - * example, the code for the all-too-familiar STATUS_ACCESS_VIOLATION is - * 0xC0000005. A more complete set of exception codes can be found in - * NTSTATUS.H from the Windows NT DDK. + * The comprehensive exception list is included in ntstatus.h from the + * Windows Driver Kit (WDK). A subset of the list is also included in + * winnt.h from the Windows SDK. Defining WIN32_NO_STATUS before including + * windows.h helps to avoid any conflicts. * * Some day we might want to print descriptions for the most common * exceptions, rather than printing an include file name. We could use |