diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-09-09 14:21:40 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-09-09 14:21:40 -0400 |
| commit | 3146f5257f16d34c95163974f42a13d99141b977 (patch) | |
| tree | b20d2f21b654a1e5035dec9e12b6bf555d70fdfd /src | |
| parent | 73ff3a0abbbcb2c623731b88f2d1334bc67e5820 (diff) | |
| download | postgresql-3146f5257f16d34c95163974f42a13d99141b977.tar.gz postgresql-3146f5257f16d34c95163974f42a13d99141b977.zip | |
Be more careful about port selection in src/test/ldap/.
Don't just assume that the next port is free; it might not be, or
if we're really unlucky it might even be out of the TCP range.
Do it honestly with two get_free_port() calls instead.
This is surely a pretty low-probability problem, but I think it
explains a buildfarm failure seen today, so let's fix it.
Back-patch to v11 where this script was added.
Discussion: https://postgr.es/m/25124.1568052346@sss.pgh.pa.us
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/ldap/t/001_auth.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.pl index daa2270cdfa..f8941144f5e 100644 --- a/src/test/ldap/t/001_auth.pl +++ b/src/test/ldap/t/001_auth.pl @@ -56,7 +56,7 @@ my $slapd_logfile = "${TestLib::log_path}/slapd.log"; my $ldap_conf = "${TestLib::tmp_check}/ldap.conf"; my $ldap_server = 'localhost'; my $ldap_port = get_free_port(); -my $ldaps_port = $ldap_port + 1; +my $ldaps_port = get_free_port(); my $ldap_url = "ldap://$ldap_server:$ldap_port"; my $ldaps_url = "ldaps://$ldap_server:$ldaps_port"; my $ldap_basedn = 'dc=example,dc=net'; |