diff options
| author | Andres Freund <andres@anarazel.de> | 2022-03-31 11:18:25 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2022-03-31 11:19:24 -0700 |
| commit | 28bdfa2adfc6afe4121614b500bfcb27b7c6b94c (patch) | |
| tree | af025504579a7af9da4b9c90fdc575dc04d1c1ef /src | |
| parent | d5f43a1a10f688e2437ffb7d454d0a2d57308bff (diff) | |
| download | postgresql-28bdfa2adfc6afe4121614b500bfcb27b7c6b94c.tar.gz postgresql-28bdfa2adfc6afe4121614b500bfcb27b7c6b94c.zip | |
Print information about type of test and subdirectory before running tests.
When testing check-world it's hard to know what the test the test failure
output belongs to. The tap test output is especially problematic, partially
due to our practice of reusing test names like 001_basic.pl.
This isn't a real issue on the buildfarm, which invokes tests separately, but
locally and for CI it's quite annoying.
To fix, the test target provisos in Makefile.global.in now output
echo "+++ (regress|isolation|tap) [install-]check in $(subdir) +++"
before running the tests.
Discussion: https://postgr.es/m/20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de
Diffstat (limited to 'src')
| -rw-r--r-- | src/Makefile.global.in | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/Makefile.global.in b/src/Makefile.global.in index 0726b2020ff..07a9e52a185 100644 --- a/src/Makefile.global.in +++ b/src/Makefile.global.in @@ -448,6 +448,7 @@ ifeq ($(enable_tap_tests),yes) ifndef PGXS define prove_installcheck +echo "+++ tap install-check in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -458,6 +459,7 @@ cd $(srcdir) && \ endef else # PGXS case define prove_installcheck +echo "+++ tap install-check in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -469,6 +471,7 @@ endef endif # PGXS define prove_check +echo "+++ tap check in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -663,6 +666,7 @@ pg_regress_locale_flags = $(if $(ENCODING),--encoding=$(ENCODING)) $(NOLOCALE) pg_regress_clean_files = results/ regression.diffs regression.out tmp_check/ tmp_check_iso/ log/ output_iso/ pg_regress_check = \ + echo "+++ regress check in $(subdir) +++" && \ $(with_temp_install) \ $(top_builddir)/src/test/regress/pg_regress \ --temp-instance=./tmp_check \ @@ -671,12 +675,14 @@ pg_regress_check = \ $(TEMP_CONF) \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_regress_installcheck = \ + echo "+++ regress install-check in $(subdir) +++" && \ $(top_builddir)/src/test/regress/pg_regress \ --inputdir=$(srcdir) \ --bindir='$(bindir)' \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_isolation_regress_check = \ + echo "+++ isolation check in $(subdir) +++" && \ $(with_temp_install) \ $(top_builddir)/src/test/isolation/pg_isolation_regress \ --temp-instance=./tmp_check_iso \ @@ -685,6 +691,7 @@ pg_isolation_regress_check = \ $(TEMP_CONF) \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_isolation_regress_installcheck = \ + echo "+++ isolation install-check in $(subdir) +++" && \ $(top_builddir)/src/test/isolation/pg_isolation_regress \ --inputdir=$(srcdir) --outputdir=output_iso \ --bindir='$(bindir)' \ |