diff options
| author | Andres Freund <andres@anarazel.de> | 2020-08-19 18:19:52 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2020-08-19 18:24:33 -0700 |
| commit | 1fe1f42e3e85279e1cb8b004b3b076a04bde4cee (patch) | |
| tree | 716bd049bed8d5f64568ee1e069095b820ffa78b /src | |
| parent | 20729324078055a4d9654fc5af9570fe625786a5 (diff) | |
| download | postgresql-1fe1f42e3e85279e1cb8b004b3b076a04bde4cee.tar.gz postgresql-1fe1f42e3e85279e1cb8b004b3b076a04bde4cee.zip | |
Acquire ProcArrayLock exclusively in ProcArrayClearTransaction.
This corrects an oversight by me in 20729324078, which made
ProcArrayClearTransaction() increment xactCompletionCount. That requires an
exclusive lock, obviously.
There's other approaches that avoid the exclusive acquisition, but given that a
2PC commit is fairly heavyweight, it doesn't seem worth doing so. I've not been
able to measure a performance difference, unsurprisingly. I did add a
comment documenting that we could do so, should it ever become a bottleneck.
Reported-By: Tom Lane <tgl@sss.pgh.pa.us>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/1355915.1597794204@sss.pgh.pa.us
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/storage/ipc/procarray.c | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 51f8099cad2..60b7a5db8e0 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -840,13 +840,20 @@ ProcArrayClearTransaction(PGPROC *proc) size_t pgxactoff; /* - * We can skip locking ProcArrayLock exclusively here, because this action - * does not actually change anyone's view of the set of running XIDs: our - * entry is duplicate with the gxact that has already been inserted into - * the ProcArray. But need it in shared mode for pgproc->pgxactoff to stay - * the same. + * Currently we need to lock ProcArrayLock exclusively here, as we + * increment xactCompletionCount below. We also need it at least in shared + * mode for pgproc->pgxactoff to stay the same below. + * + * We could however, as this action does not actually change anyone's view + * of the set of running XIDs (our entry is duplicate with the gxact that + * has already been inserted into the ProcArray), lower the lock level to + * shared if we were to make xactCompletionCount an atomic variable. But + * that doesn't seem worth it currently, as a 2PC commit is heavyweight + * enough for this not to be the bottleneck. If it ever becomes a + * bottleneck it may also be worth considering to combine this with the + * subsequent ProcArrayRemove() */ - LWLockAcquire(ProcArrayLock, LW_SHARED); + LWLockAcquire(ProcArrayLock, LW_EXCLUSIVE); pgxactoff = proc->pgxactoff; |