aboutsummaryrefslogtreecommitdiff
path: root/src/test/perl/PostgresNode.pm
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2018-01-05 20:33:26 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2018-01-05 20:33:26 -0500
commitccf312a4488ab8bb38dfd87168bf8915045d1a82 (patch)
treef3e18a670acbffe5986d0852b83fdf3a5c7fdd38 /src/test/perl/PostgresNode.pm
parent3cac0ec85992829c160bdd8a370dd4676d42f58c (diff)
downloadpostgresql-ccf312a4488ab8bb38dfd87168bf8915045d1a82.tar.gz
postgresql-ccf312a4488ab8bb38dfd87168bf8915045d1a82.zip
Remove return values of ConditionVariableSignal/Broadcast.
In the wake of commit aced5a92b, the semantics of these results are a bit squishy: we can tell whether we signaled some other process(es), but we do not know which ones were real waiters versus mere sentinels for ConditionVariableBroadcast operations. It does not help much that ConditionVariableBroadcast will attempt to pass on the signal to the next real waiter, because (a) there might not be one, and (b) that will only happen awhile later, anyway. So these results could overstate how much effect the calls really had. However, no existing caller of either function pays any attention to its result value, so it seems reasonable to just define that as a required property of a correct algorithm. To encourage correctness and save some tiny number of cycles, change both functions to return void. Patch by me, per an observation by Thomas Munro. No back-patch, since if any third parties happen to be using these functions, they might not appreciate an API break in a minor release. Discussion: https://postgr.es/m/CAEepm=0NWKehYw7NDoUSf8juuKOPRnCyY3vuaSvhrEWsOTAa3w@mail.gmail.com
Diffstat (limited to 'src/test/perl/PostgresNode.pm')
0 files changed, 0 insertions, 0 deletions