diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-04-06 09:53:06 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-04-06 09:53:06 +0900 |
| commit | 6d41dd045ada28ee14182112fc4cf50fb3879d28 (patch) | |
| tree | 2ee7911daf6d5dbaf9664e0f4b49ccbfb4be5067 /src/test/perl/PostgresNode.pm | |
| parent | f6b8f19a084ce949522fcbc940dc116c034cfc47 (diff) | |
| download | postgresql-6d41dd045ada28ee14182112fc4cf50fb3879d28.tar.gz postgresql-6d41dd045ada28ee14182112fc4cf50fb3879d28.zip | |
Change PostgresNode::connect_fails() to never send down queries
This type of failure is similar to what has been fixed in c757a3da,
where an authentication failure combined with psql pushing a command
down its communication pipe causes a test failure. This routine is
designed to fail, so sending a query has little sense anyway.
Per buildfarm members gaur and hoverfly, based on an analysis and fix
from Tom Lane.
Discussion: https://postgr.es/m/513200.1617634642@sss.pgh.pa.us
Diffstat (limited to 'src/test/perl/PostgresNode.pm')
| -rw-r--r-- | src/test/perl/PostgresNode.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index bbde34c9291..ec202f1b6e5 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -1938,7 +1938,7 @@ sub connect_fails # have set up things properly, and this should not block. my ($ret, $stdout, $stderr) = $self->psql( 'postgres', - "SELECT \$\$connected with $connstr\$\$", + undef, extra_params => ['-w'], connstr => "$connstr"); |