aboutsummaryrefslogtreecommitdiff
path: root/src/test/perl/PostgresNode.pm
diff options
context:
space:
mode:
authorAndrew Dunstan <andrew@dunslane.net>2018-05-09 10:14:46 -0400
committerAndrew Dunstan <andrew@dunslane.net>2018-05-09 10:14:46 -0400
commit35361ee78890ce5b559a710c8fa2fdfa843eb280 (patch)
tree22a5a33c4e327f6260f85e1bf36f54759da7f2be /src/test/perl/PostgresNode.pm
parent286bb240e1c8e279efa2d805c7f700abfb771925 (diff)
downloadpostgresql-35361ee78890ce5b559a710c8fa2fdfa843eb280.tar.gz
postgresql-35361ee78890ce5b559a710c8fa2fdfa843eb280.zip
Restrict vertical tightness to parentheses in Perl code
The vertical tightness settings collapse vertical whitespace between opening and closing brackets (parentheses, square brakets and braces). This can make data structures in particular harder to read, and is not very consistent with our style in non-Perl code. This patch restricts that setting to parentheses only, and reformats all the perl code accordingly. Not applying this to parentheses has some unfortunate effects, so the consensus is to keep the setting for parentheses and not for the others. The diff for this patch does highlight some places where structures should have trailing commas. They can be added manually, as there is no automatic tool to do so. Discussion: https://postgr.es/m/a2f2b87c-56be-c070-bfc0-36288b4b41c1@2ndQuadrant.com
Diffstat (limited to 'src/test/perl/PostgresNode.pm')
-rw-r--r--src/test/perl/PostgresNode.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index 53efb576e03..82a2611a1e9 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -155,7 +155,8 @@ sub new
_host => $pghost,
_basedir => "$TestLib::tmp_check/t_${testname}_${name}_data",
_name => $name,
- _logfile => "$TestLib::log_path/${testname}_${name}.log" };
+ _logfile => "$TestLib::log_path/${testname}_${name}.log"
+ };
bless $self, $class;
mkdir $self->{_basedir}