aboutsummaryrefslogtreecommitdiff
path: root/src/test/modules/commit_ts
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-07-01 14:25:09 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-07-01 14:25:09 -0400
commitb0f069d931f0a3d4a39aeeb230baf2f2b18cb3c3 (patch)
tree080a44f7a5fc251dfb2aded6361cc4d3a6ff20a1 /src/test/modules/commit_ts
parentf32678c0163d7d966560bdaf41bfbc2cf179a260 (diff)
downloadpostgresql-b0f069d931f0a3d4a39aeeb230baf2f2b18cb3c3.tar.gz
postgresql-b0f069d931f0a3d4a39aeeb230baf2f2b18cb3c3.zip
Clean up misuse and nonuse of poll_query_until().
Several callers of PostgresNode::poll_query_until() neglected to check for failure; I do not think that's optional. Also, rewrite one place that had reinvented poll_query_until() for no very good reason.
Diffstat (limited to 'src/test/modules/commit_ts')
-rw-r--r--src/test/modules/commit_ts/t/003_standby_2.pl3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/modules/commit_ts/t/003_standby_2.pl b/src/test/modules/commit_ts/t/003_standby_2.pl
index 2fd561115cb..eccaf07561e 100644
--- a/src/test/modules/commit_ts/t/003_standby_2.pl
+++ b/src/test/modules/commit_ts/t/003_standby_2.pl
@@ -55,7 +55,8 @@ $master->append_conf('postgresql.conf', 'track_commit_timestamp = off');
$master->restart;
system_or_bail('pg_ctl', '-D', $standby->data_dir, 'promote');
-$standby->poll_query_until('postgres', "SELECT pg_is_in_recovery() <> true");
+$standby->poll_query_until('postgres', "SELECT NOT pg_is_in_recovery()")
+ or die "standby never exited recovery";
$standby->safe_psql('postgres', "create table t11()");
my $standby_ts = $standby->safe_psql('postgres',