diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2025-02-20 19:49:27 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2025-02-20 19:49:27 +0100 |
| commit | 3e4d868615408370fe6c2977c32f45a47c372b00 (patch) | |
| tree | ad4dd9cb02d58fb938f2f8e1a8c352bcd9bfe314 /src/interfaces | |
| parent | ab84d0ff806dd791ea9da5f1ca302daf3cf42980 (diff) | |
| download | postgresql-3e4d868615408370fe6c2977c32f45a47c372b00.tar.gz postgresql-3e4d868615408370fe6c2977c32f45a47c372b00.zip | |
Remove various unnecessary (char *) casts
Remove a number of (char *) casts that are unnecessary. Or in some
cases, rewrite the code to make the purpose of the cast clearer.
Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
Diffstat (limited to 'src/interfaces')
| -rw-r--r-- | src/interfaces/ecpg/ecpglib/descriptor.c | 4 | ||||
| -rw-r--r-- | src/interfaces/ecpg/ecpglib/execute.c | 2 | ||||
| -rw-r--r-- | src/interfaces/ecpg/pgtypeslib/numeric.c | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/interfaces/ecpg/ecpglib/descriptor.c b/src/interfaces/ecpg/ecpglib/descriptor.c index 8525a6812f2..651d5c8b2ed 100644 --- a/src/interfaces/ecpg/ecpglib/descriptor.c +++ b/src/interfaces/ecpg/ecpglib/descriptor.c @@ -198,7 +198,7 @@ get_char_item(int lineno, void *var, enum ECPGttype vartype, char *value, int va case ECPGt_char: case ECPGt_unsigned_char: case ECPGt_string: - strncpy((char *) var, value, varcharsize); + strncpy(var, value, varcharsize); break; case ECPGt_varchar: { @@ -597,7 +597,7 @@ set_desc_attr(struct descriptor_item *desc_item, struct variable *var, } ecpg_free(desc_item->data); /* free() takes care of a potential NULL value */ - desc_item->data = (char *) tobeinserted; + desc_item->data = tobeinserted; } diff --git a/src/interfaces/ecpg/ecpglib/execute.c b/src/interfaces/ecpg/ecpglib/execute.c index b5089eac787..f52da06de9a 100644 --- a/src/interfaces/ecpg/ecpglib/execute.c +++ b/src/interfaces/ecpg/ecpglib/execute.c @@ -278,7 +278,7 @@ ecpg_is_type_an_array(int type, const struct statement *stmt, const struct varia isarray = ECPG_ARRAY_NONE; else { - isarray = (atoi((char *) PQgetvalue(query, 0, 0)) == -1) ? ECPG_ARRAY_ARRAY : ECPG_ARRAY_VECTOR; + isarray = (atoi(PQgetvalue(query, 0, 0)) == -1) ? ECPG_ARRAY_ARRAY : ECPG_ARRAY_VECTOR; if (ecpg_dynamic_type(type) == SQL3_CHARACTER || ecpg_dynamic_type(type) == SQL3_CHARACTER_VARYING) { diff --git a/src/interfaces/ecpg/pgtypeslib/numeric.c b/src/interfaces/ecpg/pgtypeslib/numeric.c index 35e7b92da40..bb2a86981ca 100644 --- a/src/interfaces/ecpg/pgtypeslib/numeric.c +++ b/src/interfaces/ecpg/pgtypeslib/numeric.c @@ -232,7 +232,7 @@ get_str_from_var(numeric *var, int dscale) if (var->sign == NUMERIC_NAN) { - str = (char *) pgtypes_alloc(4); + str = pgtypes_alloc(4); if (str == NULL) return NULL; sprintf(str, "NaN"); @@ -269,7 +269,7 @@ get_str_from_var(numeric *var, int dscale) /* * Allocate space for the result */ - if ((str = (char *) pgtypes_alloc(Max(0, dscale) + Max(0, var->weight) + 4)) == NULL) + if ((str = pgtypes_alloc(Max(0, dscale) + Max(0, var->weight) + 4)) == NULL) return NULL; cp = str; |