diff options
| author | Bruce Momjian <bruce@momjian.us> | 2014-04-16 19:46:51 -0400 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2014-04-16 19:46:51 -0400 |
| commit | 5d305d86bd917723f09ab4f15c075d90586a210a (patch) | |
| tree | 4a9a18e0e4c2a0df2263b68fc5e8aa5d8098dd87 /src/interfaces/libpq/fe-misc.c | |
| parent | be5f7fff470066dc3ee655b25840733eb9006426 (diff) | |
| download | postgresql-5d305d86bd917723f09ab4f15c075d90586a210a.tar.gz postgresql-5d305d86bd917723f09ab4f15c075d90586a210a.zip | |
libpq: use pgsocket for socket values, for portability
Previously, 'int' was used for socket values in libpq, but socket values
are unsigned on Windows. This is a style correction.
Initial patch and previous PGINVALID_SOCKET initial patch by Joel
Jacobson, modified by me
Report from PVS-Studio
Diffstat (limited to 'src/interfaces/libpq/fe-misc.c')
| -rw-r--r-- | src/interfaces/libpq/fe-misc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c index a7afd425562..cc487b22eec 100644 --- a/src/interfaces/libpq/fe-misc.c +++ b/src/interfaces/libpq/fe-misc.c @@ -604,7 +604,7 @@ pqReadData(PGconn *conn) int someread = 0; int nread; - if (conn->sock < 0) + if (conn->sock == PGINVALID_SOCKET) { printfPQExpBuffer(&conn->errorMessage, libpq_gettext("connection not open\n")); @@ -800,7 +800,7 @@ pqSendSome(PGconn *conn, int len) int remaining = conn->outCount; int result = 0; - if (conn->sock < 0) + if (conn->sock == PGINVALID_SOCKET) { printfPQExpBuffer(&conn->errorMessage, libpq_gettext("connection not open\n")); @@ -1011,7 +1011,7 @@ pqSocketCheck(PGconn *conn, int forRead, int forWrite, time_t end_time) if (!conn) return -1; - if (conn->sock < 0) + if (conn->sock == PGINVALID_SOCKET) { printfPQExpBuffer(&conn->errorMessage, libpq_gettext("socket not open\n")); |