diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-08-27 22:13:44 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-08-27 22:13:44 +0000 |
commit | 4e5fbb34b361102df41642a6ed9676b8b6a1e75f (patch) | |
tree | 56acd956f301ecd6f33904d5ac05d984ac6bd413 /src/include/optimizer/paths.h | |
parent | 9e56c5a4cff7edb145729c7ba2b19dd8cf1c45cf (diff) | |
download | postgresql-4e5fbb34b361102df41642a6ed9676b8b6a1e75f.tar.gz postgresql-4e5fbb34b361102df41642a6ed9676b8b6a1e75f.zip |
Change the division of labor between grouping_planner and query_planner
so that the latter estimates the number of groups that grouping will
produce. This is needed because it is primarily query_planner that
makes the decision between fast-start and fast-finish plans, and in the
original coding it was unable to make more than a crude rule-of-thumb
choice when the query involved grouping. This revision helps us make
saner choices for queries like SELECT ... GROUP BY ... LIMIT, as in a
recent example from Mark Kirkwood. Also move the responsibility for
canonicalizing sort_pathkeys and group_pathkeys into query_planner;
this information has to be available anyway to support the first change,
and doing it this way lets us get rid of compare_noncanonical_pathkeys
entirely.
Diffstat (limited to 'src/include/optimizer/paths.h')
-rw-r--r-- | src/include/optimizer/paths.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/include/optimizer/paths.h b/src/include/optimizer/paths.h index 8f26c8e8f0d..7c8108b000a 100644 --- a/src/include/optimizer/paths.h +++ b/src/include/optimizer/paths.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/optimizer/paths.h,v 1.86 2005/07/28 20:26:22 tgl Exp $ + * $PostgreSQL: pgsql/src/include/optimizer/paths.h,v 1.87 2005/08/27 22:13:44 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -102,9 +102,6 @@ extern void generate_implied_equalities(PlannerInfo *root); extern List *canonicalize_pathkeys(PlannerInfo *root, List *pathkeys); extern PathKeysComparison compare_pathkeys(List *keys1, List *keys2); extern bool pathkeys_contained_in(List *keys1, List *keys2); -extern PathKeysComparison compare_noncanonical_pathkeys(List *keys1, - List *keys2); -extern bool noncanonical_pathkeys_contained_in(List *keys1, List *keys2); extern Path *get_cheapest_path_for_pathkeys(List *paths, List *pathkeys, CostSelector cost_criterion); extern Path *get_cheapest_fractional_path_for_pathkeys(List *paths, |