diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-08-12 18:46:01 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-08-12 18:46:01 -0400 |
| commit | 46b5e7c4b5befbf6ac86d827a3a58f1f02c7338e (patch) | |
| tree | d650f4d3293ec1d27961b17baa7cb5a020a973d7 /src/include/c.h | |
| parent | d11eae09e48694ad6b4139bbb7d7b112833301f5 (diff) | |
| download | postgresql-46b5e7c4b5befbf6ac86d827a3a58f1f02c7338e.tar.gz postgresql-46b5e7c4b5befbf6ac86d827a3a58f1f02c7338e.zip | |
Revert "Distinguish printf-like functions that support %m from those that don't."
This reverts commit 3a60c8ff892a8242b907f44702bfd9f1ff877d45. Buildfarm
results show that that caused a whole bunch of new warnings on platforms
where gcc believes the local printf to be non-POSIX-compliant. This
problem outweighs the hypothetical-anyway possibility of getting warnings
for misuse of %m. We could use gnu_printf archetype when we've substituted
src/port/snprintf.c, but that brings us right back to the problem of not
getting warnings for %m.
A possible answer is to attack it in the other direction by insisting
that %m support be included in printf's feature set, but that will take
more investigation. In the meantime, revert the previous change, and
update the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explain
what's going on.
Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
Diffstat (limited to 'src/include/c.h')
| -rw-r--r-- | src/include/c.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/include/c.h b/src/include/c.h index 0a4757e29fd..1e50103095b 100644 --- a/src/include/c.h +++ b/src/include/c.h @@ -126,14 +126,10 @@ /* GCC and XLC support format attributes */ #if defined(__GNUC__) || defined(__IBMC__) #define pg_attribute_format_arg(a) __attribute__((format_arg(a))) -/* Use for functions wrapping stdio's printf, which often doesn't take %m: */ -#define pg_attribute_printf(f,a) __attribute__((format(printf, f, a))) -/* Use for elog/ereport, which implement %m for themselves: */ -#define pg_attribute_printf_m(f,a) __attribute__((format(PG_PRINTF_ATTRIBUTE_M, f, a))) +#define pg_attribute_printf(f,a) __attribute__((format(PG_PRINTF_ATTRIBUTE, f, a))) #else #define pg_attribute_format_arg(a) #define pg_attribute_printf(f,a) -#define pg_attribute_printf_m(f,a) #endif /* GCC, Sunpro and XLC support aligned, packed and noreturn */ |