diff options
author | Vadim B. Mikheev <vadim4o@yahoo.com> | 1999-06-10 14:17:12 +0000 |
---|---|---|
committer | Vadim B. Mikheev <vadim4o@yahoo.com> | 1999-06-10 14:17:12 +0000 |
commit | 78f7ccc9822bc5b2206c36308640e2aad94e4f55 (patch) | |
tree | 904e731545537362897de3c5161ad99284dca5b3 /src/include/access/transam.h | |
parent | c37ecaf8d558d4e6415417adba7191934202e1d2 (diff) | |
download | postgresql-78f7ccc9822bc5b2206c36308640e2aad94e4f55.tar.gz postgresql-78f7ccc9822bc5b2206c36308640e2aad94e4f55.zip |
1. Fix for elog(ERROR, "EvalPlanQual: t_xmin is uncommitted ?!")
and possibly for other cases too:
DO NOT cache status of transaction in unknown state
(i.e. non-committed and non-aborted ones)
Example:
T1 reads row updated/inserted by running T2 and cache T2 status.
T2 commits.
Now T1 reads a row updated by T2 and with HEAP_XMAX_COMMITTED
in t_infomask (so cached T2 status is not changed).
Now T1 EvalPlanQual gets updated row version without HEAP_XMIN_COMMITTED
-> TransactionIdDidCommit(t_xmin) and TransactionIdDidAbort(t_xmin)
return FALSE and T2 decides that t_xmin is not committed and gets
ERROR above.
It's too late to find more smart way to handle such cases and so
I just changed xact status caching and got rid TransactionIdFlushCache()
from code.
Changed: transam.c, xact.c, lmgr.c and transam.h - last three
just because of TransactionIdFlushCache() is removed.
2. heapam.c:
T1 marked a row for update. T2 waits for T1 commit/abort.
T1 commits. T3 updates the row before T2 locks row page.
Now T2 sees that new row t_xmax is different from xact id (T1)
T2 was waiting for. Old code did Assert here. New one goes to
HeapTupleSatisfiesUpdate. Obvious changes too.
3. Added Assert to vacuum.c
4. bufmgr.c: break
Assert(buf->r_locks == 0 && !buf->ri_lock)
into two Asserts.
Diffstat (limited to 'src/include/access/transam.h')
-rw-r--r-- | src/include/access/transam.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/include/access/transam.h b/src/include/access/transam.h index 23fc2b59f0b..2551278f129 100644 --- a/src/include/access/transam.h +++ b/src/include/access/transam.h @@ -6,7 +6,7 @@ * * Copyright (c) 1994, Regents of the University of California * - * $Id: transam.h,v 1.21 1999/05/25 22:42:35 momjian Exp $ + * $Id: transam.h,v 1.22 1999/06/10 14:17:12 vadim Exp $ * * NOTES * Transaction System Version 101 now support proper oid @@ -145,7 +145,6 @@ extern bool TransactionIdDidCommit(TransactionId transactionId); extern bool TransactionIdDidAbort(TransactionId transactionId); extern void TransactionIdCommit(TransactionId transactionId); extern void TransactionIdAbort(TransactionId transactionId); -extern void TransactionIdFlushCache(void); /* in transam/transsup.c */ extern void AmiTransactionOverride(bool flag); |