diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-03-12 10:02:54 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-03-12 10:02:54 +0900 |
| commit | 2c8118ee5d980e11f73683fcda2329c323aa381e (patch) | |
| tree | 7527eb2a94bc9cc8821ff9afba62e03918dff351 /src/bin/pg_upgrade/function.c | |
| parent | 3045324214467dd3f0bef31f6f33562b9eb93aa3 (diff) | |
| download | postgresql-2c8118ee5d980e11f73683fcda2329c323aa381e.tar.gz postgresql-2c8118ee5d980e11f73683fcda2329c323aa381e.zip | |
Use printf's %m format instead of strerror(errno) in more places
Most callers of strerror() are removed from the backend code. The
remaining callers require special handling with a saved errno from a
previous system call. The frontend code still needs strerror() where
error states need to be handled outside of fprintf.
Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.
Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.
Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org
Diffstat (limited to 'src/bin/pg_upgrade/function.c')
| -rw-r--r-- | src/bin/pg_upgrade/function.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/bin/pg_upgrade/function.c b/src/bin/pg_upgrade/function.c index d65153de819..7e3abed0985 100644 --- a/src/bin/pg_upgrade/function.c +++ b/src/bin/pg_upgrade/function.c @@ -186,8 +186,7 @@ check_loadable_libraries(void) was_load_failure = true; if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL) - pg_fatal("could not open file \"%s\": %s", - output_path, strerror(errno)); + pg_fatal("could not open file \"%s\": %m", output_path); fprintf(script, _("could not load library \"%s\": %s"), lib, PQerrorMessage(conn)); |