This patch implements FOR EACH STATEMENT triggers, per my email to

-hackers a couple days ago.

Notes/caveats:

        - added regression tests for the new functionality, all
          regression tests pass on my machine

        - added pg_dump support

        - updated PL/PgSQL to support per-statement triggers; didn't
          look at the other procedural languages.

        - there's (even) more code duplication in trigger.c than there
          was previously. Any suggestions on how to refactor the
          ExecXXXTriggers() functions to reuse more code would be
          welcome -- I took a brief look at it, but couldn't see an
          easy way to do it (there are several subtly-different
          versions of the code in question)

        - updated the documentation. I also took the liberty of
          removing a big chunk of duplicated syntax documentation in
          the Programmer's Guide on triggers, and moving that
          information to the CREATE TRIGGER reference page.

        - I also included some spelling fixes and similar small
          cleanups I noticed while making the changes. If you'd like
          me to split those into a separate patch, let me know.

Neil Conway

1 files changed, 9 insertions, 15 deletions

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index dc2bdd83d5b..09b9e4ac697 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -7,22 +7,12 @@
  * Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	pg_dump will read the system catalogs in a database and
- *	dump out a script that reproduces
- *	the schema of the database in terms of
- *		  user-defined types
- *		  user-defined functions
- *		  tables
- *		  indexes
- *		  aggregates
- *		  operators
- *		  privileges
- *
- * the output script is SQL that is understood by PostgreSQL
- *
+ *	pg_dump will read the system catalogs in a database and dump out a
+ *	script that reproduces the schema in terms of SQL that is understood
+ *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.307 2002/11/15 02:52:18 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.308 2002/11/23 03:59:08 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -6345,7 +6335,11 @@ dumpTriggers(Archive *fout, TableInfo *tblinfo, int numTables)
 
 			}
 
-			appendPQExpBuffer(query, "    FOR EACH ROW\n    ");
+			if (TRIGGER_FOR_ROW(tgtype))
+				appendPQExpBuffer(query, "    FOR EACH ROW\n    ");
+			else
+				appendPQExpBuffer(query, "    FOR EACH STATEMENT\n    ");
+
 			/* In 7.3, result of regproc is already quoted */
 			if (g_fout->remoteVersion >= 70300)
 				appendPQExpBuffer(query, "EXECUTE PROCEDURE %s (",