diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-02-18 01:29:10 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-02-18 01:29:10 +0000 |
| commit | c0d5be5d6a736d2ee8141e920bc3de8e001bf6d9 (patch) | |
| tree | f46f456a6b66217164dae1cbc36f975bd9679a00 /src/bin/pg_dump/dumputils.c | |
| parent | 2b44d74dd4caa0d5cec2aeb0ceec7923b69109d3 (diff) | |
| download | postgresql-c0d5be5d6a736d2ee8141e920bc3de8e001bf6d9.tar.gz postgresql-c0d5be5d6a736d2ee8141e920bc3de8e001bf6d9.zip | |
Fix up pg_dump's treatment of large object ownership and ACLs. We now emit
a separate archive entry for each BLOB, and use pg_dump's standard methods
for dealing with its ownership, ACL if any, and comment if any. This means
that switches like --no-owner and --no-privileges do what they're supposed
to. Preliminary testing says that performance is still reasonable even
with many blobs, though we'll have to see how that shakes out in the field.
KaiGai Kohei, revised by me
Diffstat (limited to 'src/bin/pg_dump/dumputils.c')
| -rw-r--r-- | src/bin/pg_dump/dumputils.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/bin/pg_dump/dumputils.c b/src/bin/pg_dump/dumputils.c index e448e388d40..3452944a426 100644 --- a/src/bin/pg_dump/dumputils.c +++ b/src/bin/pg_dump/dumputils.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.c,v 1.53 2010/01/02 16:57:59 momjian Exp $ + * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.c,v 1.54 2010/02/18 01:29:10 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -486,7 +486,8 @@ parsePGArray(const char *atext, char ***itemarray, int *nitems) * name: the object name, in the form to use in the commands (already quoted) * subname: the sub-object name, if any (already quoted); NULL if none * type: the object type (as seen in GRANT command: must be one of - * TABLE, SEQUENCE, FUNCTION, LANGUAGE, SCHEMA, DATABASE, or TABLESPACE) + * TABLE, SEQUENCE, FUNCTION, LANGUAGE, SCHEMA, DATABASE, TABLESPACE, + * FOREIGN DATA WRAPPER, SERVER, or LARGE OBJECT) * acls: the ACL string fetched from the database * owner: username of object owner (will be passed through fmtId); can be * NULL or empty string to indicate "no owner known" |