diff options
| author | Michael Paquier <michael@paquier.xyz> | 2025-04-28 09:08:15 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2025-04-28 09:08:15 +0900 |
| commit | b225c5e76ed1053e505e392423b0dab065a3b813 (patch) | |
| tree | 2cefc5584c85cdf5110963c680cc5c8f416d35fc /src/backend | |
| parent | 1aa7cf9eb85972aaf2969306e84f5fc794fbef7f (diff) | |
| download | postgresql-b225c5e76ed1053e505e392423b0dab065a3b813.tar.gz postgresql-b225c5e76ed1053e505e392423b0dab065a3b813.zip | |
Remove circular #include's between wait_event.h and wait_event_types.h
wait_event_types.h is generated by the code, and included wait_event.h.
wait_event.h did the opposite move, including wait_event_types.h,
causing a circular dependency between both.
wait_event_types.h only needs to now about the wait event classes, so
this information is moved into its own file, and wait_event_types.h uses
this new header so as it does not depend anymore on wait_event.h.
Note that such errors can be found with clang-tidy, with commands like
this one:
clang-tidy source_file.c --checks=misc-header-include-cycle -- \
-I/install/path/include/ -I/install/path/include/server/
Issue introduced by fa88928470b5.
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/350192.1745768770@sss.pgh.pa.us
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/utils/activity/generate-wait_event_types.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/activity/generate-wait_event_types.pl b/src/backend/utils/activity/generate-wait_event_types.pl index 171bf2ae632..424ad9f115d 100644 --- a/src/backend/utils/activity/generate-wait_event_types.pl +++ b/src/backend/utils/activity/generate-wait_event_types.pl @@ -168,7 +168,7 @@ if ($gen_code) printf $h $header_comment, 'wait_event_types.h'; printf $h "#ifndef WAIT_EVENT_TYPES_H\n"; printf $h "#define WAIT_EVENT_TYPES_H\n\n"; - printf $h "#include \"utils/wait_event.h\"\n\n"; + printf $h "#include \"utils/wait_classes.h\"\n\n"; printf $c $header_comment, 'pgstat_wait_event.c'; |