diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2024-10-07 13:51:03 -0500 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2024-10-07 13:51:03 -0500 |
| commit | 5d6187d2a28326b3414c394ec4c28c51bb513c44 (patch) | |
| tree | 50be6bb91099a0d46126a07d08e64530d940e6b9 /src/backend/utils/error/elog.c | |
| parent | f391d9dc93a24923c57bb0e044161d3f0b840770 (diff) | |
| download | postgresql-5d6187d2a28326b3414c394ec4c28c51bb513c44.tar.gz postgresql-5d6187d2a28326b3414c394ec4c28c51bb513c44.zip | |
Fix Y2038 issues with MyStartTime.
Several places treat MyStartTime as a "long", which is only 32 bits
wide on some platforms. In reality, MyStartTime is a pg_time_t,
i.e., a signed 64-bit integer. This will lead to interesting bugs
on the aforementioned systems in 2038 when signed 32-bit integers
are no longer sufficient to store Unix time (e.g., "pg_ctl start"
hanging). To fix, ensure that MyStartTime is handled as a 64-bit
value everywhere. (Of course, users will need to ensure that
time_t is 64 bits wide on their system, too.)
Co-authored-by: Max Johnson
Discussion: https://postgr.es/m/CO1PR07MB905262E8AC270FAAACED66008D682%40CO1PR07MB9052.namprd07.prod.outlook.com
Backpatch-through: 12
Diffstat (limited to 'src/backend/utils/error/elog.c')
| -rw-r--r-- | src/backend/utils/error/elog.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 5cbb5b54168..987ff98067b 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -2944,12 +2944,12 @@ log_status_format(StringInfo buf, const char *format, ErrorData *edata) { char strfbuf[128]; - snprintf(strfbuf, sizeof(strfbuf) - 1, "%lx.%x", - (long) (MyStartTime), MyProcPid); + snprintf(strfbuf, sizeof(strfbuf) - 1, "%" INT64_MODIFIER "x.%x", + MyStartTime, MyProcPid); appendStringInfo(buf, "%*s", padding, strfbuf); } else - appendStringInfo(buf, "%lx.%x", (long) (MyStartTime), MyProcPid); + appendStringInfo(buf, "%" INT64_MODIFIER "x.%x", MyStartTime, MyProcPid); break; case 'p': if (padding != 0) |