diff options
| author | Noah Misch <noah@leadboat.com> | 2024-10-25 06:51:02 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-10-25 06:51:02 -0700 |
| commit | 243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704 (patch) | |
| tree | d092b3c3b261da64a5f17a35b87d67626f9591f7 /src/backend/utils/cache/syscache.c | |
| parent | 0fe173680e148984a150326b80c322a91ffa899d (diff) | |
| download | postgresql-243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704.tar.gz postgresql-243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704.zip | |
For inplace update, send nontransactional invalidations.
The inplace update survives ROLLBACK. The inval didn't, so another
backend's DDL could then update the row without incorporating the
inplace update. In the test this fixes, a mix of CREATE INDEX and ALTER
TABLE resulted in a table with an index, yet relhasindex=f. That is a
source of index corruption. Back-patch to v12 (all supported versions).
The back branch versions don't change WAL, because those branches just
added end-of-recovery SIResetAll(). All branches change the ABI of
extern function PrepareToInvalidateCacheTuple(). No PGXN extension
calls that, and there's no apparent use case in extensions.
Reviewed by Nitin Motiani and (in earlier versions) Andres Freund.
Discussion: https://postgr.es/m/20240523000548.58.nmisch@google.com
Diffstat (limited to 'src/backend/utils/cache/syscache.c')
| -rw-r--r-- | src/backend/utils/cache/syscache.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/utils/cache/syscache.c b/src/backend/utils/cache/syscache.c index 50c9440f792..f41b1c221a1 100644 --- a/src/backend/utils/cache/syscache.c +++ b/src/backend/utils/cache/syscache.c @@ -351,8 +351,7 @@ SearchSysCacheLocked1(int cacheId, /* * If an inplace update just finished, ensure we process the syscache - * inval. XXX this is insufficient: the inplace updater may not yet - * have reached AtEOXact_Inval(). See test at inplace-inval.spec. + * inval. * * If a heap_update() call just released its LOCKTAG_TUPLE, we'll * probably find the old tuple and reach "tuple concurrently updated". |