aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/cache/catcache.c
diff options
context:
space:
mode:
authorJan Wieck <JanWieck@Yahoo.com>1999-11-19 18:51:52 +0000
committerJan Wieck <JanWieck@Yahoo.com>1999-11-19 18:51:52 +0000
commit43499af4ab56a3d034b5e27f97273b612110410d (patch)
tree270213fe173e0f69ccdb619408ea60df92e0b404 /src/backend/utils/cache/catcache.c
parent58d1eeaafe9e534f7518f13b3560a66215eecf79 (diff)
downloadpostgresql-43499af4ab56a3d034b5e27f97273b612110410d.tar.gz
postgresql-43499af4ab56a3d034b5e27f97273b612110410d.zip
New parallel regression test shell and related things.
Jan
Diffstat (limited to 'src/backend/utils/cache/catcache.c')
-rw-r--r--src/backend/utils/cache/catcache.c14
1 files changed, 13 insertions, 1 deletions
diff --git a/src/backend/utils/cache/catcache.c b/src/backend/utils/cache/catcache.c
index cc86bae0fb6..423a5d72861 100644
--- a/src/backend/utils/cache/catcache.c
+++ b/src/backend/utils/cache/catcache.c
@@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
- * $Header: /cvsroot/pgsql/src/backend/utils/cache/catcache.c,v 1.51 1999/11/07 23:08:26 momjian Exp $
+ * $Header: /cvsroot/pgsql/src/backend/utils/cache/catcache.c,v 1.52 1999/11/19 18:51:48 wieck Exp $
*
*-------------------------------------------------------------------------
*/
@@ -983,11 +983,23 @@ SearchSysCache(struct catcache * cache,
* ----------------
*/
+ /* ----------
+ * It is definitely insufficient. While modifying the regression
+ * test to run independent tests concurrently it happened, that
+ * this code fails VERY often. ISTM that 'cache' points into
+ * shared memory, but that 'busy' means this backend is loading
+ * a new entry. So when another backend has set busy, this one
+ * think's it detected a recursion.
+ *
+ * Need's a smarter detection mechanism - Jan
+ *
if (cache->busy)
{
elog(ERROR, "SearchSysCache: recursive use of cache %d", cache->id);
}
cache->busy = true;
+ * ----------
+ */
/* ----------------
* open the relation associated with the cache