diff options
| author | Neil Conway <neilc@samurai.com> | 2008-01-12 10:38:32 +0000 |
|---|---|---|
| committer | Neil Conway <neilc@samurai.com> | 2008-01-12 10:38:32 +0000 |
| commit | 25b7583f67136e522b502ee2ad32ae630e521439 (patch) | |
| tree | 5e61b084dc0a1da352b6258bbc71cb81545bfa46 /src/backend/utils/adt/xml.c | |
| parent | 208d0a232147609a58a5c8a3f21c4764baf136f2 (diff) | |
| download | postgresql-25b7583f67136e522b502ee2ad32ae630e521439.tar.gz postgresql-25b7583f67136e522b502ee2ad32ae630e521439.zip | |
Minor perf tweak for _SPI_strdup(): if we're going to call strlen()
anyway, it is faster to memcpy() than to strcpy().
Diffstat (limited to 'src/backend/utils/adt/xml.c')
| -rw-r--r-- | src/backend/utils/adt/xml.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c index f61c6669034..295e826576a 100644 --- a/src/backend/utils/adt/xml.c +++ b/src/backend/utils/adt/xml.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.64 2008/01/01 19:45:53 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.65 2008/01/12 10:38:32 neilc Exp $ * *------------------------------------------------------------------------- */ @@ -1821,9 +1821,10 @@ map_sql_value_to_xml_value(Datum value, Oid type) static char * _SPI_strdup(const char *s) { - char *ret = SPI_palloc(strlen(s) + 1); + size_t len = strlen(s) + 1; + char *ret = SPI_palloc(len); - strcpy(ret, s); + memcpy(ret, s, len); return ret; } |