aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/xml.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2008-01-12 21:14:08 +0000
committerTom Lane <tgl@sss.pgh.pa.us>2008-01-12 21:14:08 +0000
commit1bbf8706ae6e7a307ac0739d9df51b47832c7d4b (patch)
treed9ca917dd398c788648e8753dda7d9d515a91824 /src/backend/utils/adt/xml.c
parent52176633720246efda688efcbeedb141ca598d00 (diff)
downloadpostgresql-1bbf8706ae6e7a307ac0739d9df51b47832c7d4b.tar.gz
postgresql-1bbf8706ae6e7a307ac0739d9df51b47832c7d4b.zip
It turns out the LIBXML_TEST_VERSION macro calls xmlInitParser().
Therefore we must xmlCleanupParser(), or we risk leaving behind dangling pointers to whatever memory context is current when xml_init() is called. This seems to fix bug #3860, though we might still want the more invasive solution being worked on by Alvaro.
Diffstat (limited to 'src/backend/utils/adt/xml.c')
-rw-r--r--src/backend/utils/adt/xml.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index 622d4e05f7f..411cd6c22ed 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.66 2008/01/12 10:50:03 neilc Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.67 2008/01/12 21:14:08 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -958,6 +958,9 @@ xml_init(void)
/* Check library compatibility */
LIBXML_TEST_VERSION;
+ /* The above calls xmlInitParser(); must clean up dangling pointers */
+ xmlCleanupParser();
+
first_time = false;
}
else