aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/pgstatfuncs.c
diff options
context:
space:
mode:
authorMagnus Hagander <magnus@hagander.net>2011-06-29 19:35:11 +0200
committerMagnus Hagander <magnus@hagander.net>2011-06-29 19:36:51 +0200
commit79aa44536f3980d324f486504cde643ce23bf5c6 (patch)
treed39e71fa7cdb29bc7bdf76499f247632f7e4c7de /src/backend/utils/adt/pgstatfuncs.c
parent21f1e15aafb13ab2430e831a3da7d4d4f525d1ce (diff)
downloadpostgresql-79aa44536f3980d324f486504cde643ce23bf5c6.tar.gz
postgresql-79aa44536f3980d324f486504cde643ce23bf5c6.zip
Protect pg_stat_reset_shared() against NULL input
Per bug #6082, reported by Steve Haslam
Diffstat (limited to 'src/backend/utils/adt/pgstatfuncs.c')
-rw-r--r--src/backend/utils/adt/pgstatfuncs.c14
1 files changed, 11 insertions, 3 deletions
diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c
index 12dbff4c9a9..4d07bdd24bd 100644
--- a/src/backend/utils/adt/pgstatfuncs.c
+++ b/src/backend/utils/adt/pgstatfuncs.c
@@ -1537,9 +1537,17 @@ pg_stat_reset(PG_FUNCTION_ARGS)
Datum
pg_stat_reset_shared(PG_FUNCTION_ARGS)
{
- char *target = text_to_cstring(PG_GETARG_TEXT_PP(0));
-
- pgstat_reset_shared_counters(target);
+ if (PG_ARGISNULL(0))
+ /*
+ * Same error message as in pgstat_reset_shared_counters(),
+ * to keep translations the same.
+ */
+ ereport(ERROR,
+ (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+ errmsg("unrecognized reset target: \"%s\"", "null"),
+ errhint("Target must be \"bgwriter\".")));
+
+ pgstat_reset_shared_counters(text_to_cstring(PG_GETARG_TEXT_PP(0)));
PG_RETURN_VOID();
}