diff options
| author | Fujii Masao <fujii@postgresql.org> | 2021-10-06 00:16:03 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2021-10-06 00:16:03 +0900 |
| commit | 68601985e699adeb267636fd19d3d6113554bd1f (patch) | |
| tree | 147e985ef86d3c3ccbc601005a4ae256d084f932 /src/backend/utils/adt/numeric.c | |
| parent | f3fec23dbdead113700fb1b401b681fa24f1e4f4 (diff) | |
| download | postgresql-68601985e699adeb267636fd19d3d6113554bd1f.tar.gz postgresql-68601985e699adeb267636fd19d3d6113554bd1f.zip | |
Make recovery report error message when invalid page header is found.
Commit 0668719801 changed XLogPageRead() so that it validated the page
header, if invalid page header was found reset the error message and
retried reading the page, to fix the scenario where streaming standby
got stuck at a continuation record. This change hid the error message
about invalid page header, which would make it harder for users to
investigate what the actual issue was found in WAL.
To fix the issue, this commit makes XLogPageRead() report the error
message when invalid page header is found.
When not in standby mode, an invalid page header should cause recovery
to end, not retry reading the page, so XLogPageRead() doesn't need to
validate the page header for the retry. Instead, ReadPageInternal() should
be responsible for the validation in that case. Therefore this commit
changes XLogPageRead() so that if not in standby mode it doesn't validate
the page header for the retry.
Reported-by: Yugo Nagata
Author: Yugo Nagata, Kyotaro Horiguchi
Reviewed-by: Ranier Vilela, Fujii Masao
Discussion: https://postgr.es/m/20210718045505.32f463ed6c227111038d8ae4@sraoss.co.jp
Diffstat (limited to 'src/backend/utils/adt/numeric.c')
0 files changed, 0 insertions, 0 deletions