diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-04 16:09:33 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-04 16:09:33 -0500 |
| commit | dbca84f04ed5debe748029699aa44fa86beca32d (patch) | |
| tree | d75996d4d57e39b02dae97bf434b2ade56dacc39 /src/backend/utils/adt/misc.c | |
| parent | d77ff69341f20db348ba2a4b29c522a93ac8e901 (diff) | |
| download | postgresql-dbca84f04ed5debe748029699aa44fa86beca32d.tar.gz postgresql-dbca84f04ed5debe748029699aa44fa86beca32d.zip | |
In rebuild_relation(), don't access an already-closed relcache entry.
This reliably fails with -DRELCACHE_FORCE_RELEASE, as reported by
Andrew Dunstan, and could sometimes fail in normal operation, resulting
in a wrong persistence value being used for the transient table.
It's not immediately clear to me what effects that might have beyond
the risk of a crash while accessing OldHeap->rd_rel->relpersistence,
but it's probably not good.
Bug introduced by commit f41872d0c, and made substantially worse by
commit 85b506bbf, which added a second such access significantly
later than the heap_close. I doubt the first reference could fail
in a production scenario, but the second one definitely could.
Discussion: https://postgr.es/m/7b52f900-0579-cda9-ae2e-de5da17090e6@2ndQuadrant.com
Diffstat (limited to 'src/backend/utils/adt/misc.c')
0 files changed, 0 insertions, 0 deletions