Phase 3 of pgindent updates.

Don't move parenthesized lines to the left, even if that means they
flow past the right margin.

By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis.  However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent.  That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.

This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.

This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

1 files changed, 7 insertions, 7 deletions

diff --git a/src/backend/utils/adt/misc.c b/src/backend/utils/adt/misc.c
index 9cc0b08e969..62341b84d1c 100644
--- a/src/backend/utils/adt/misc.c
+++ b/src/backend/utils/adt/misc.c
@@ -310,7 +310,7 @@ pg_terminate_backend(PG_FUNCTION_ARGS)
 	if (r == SIGNAL_BACKEND_NOSUPERUSER)
 		ereport(ERROR,
 				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-			(errmsg("must be a superuser to terminate superuser process"))));
+				 (errmsg("must be a superuser to terminate superuser process"))));
 
 	if (r == SIGNAL_BACKEND_NOPERMISSION)
 		ereport(ERROR,
@@ -352,7 +352,7 @@ pg_rotate_logfile(PG_FUNCTION_ARGS)
 	if (!Logging_collector)
 	{
 		ereport(WARNING,
-		(errmsg("rotation not possible because log collection not active")));
+				(errmsg("rotation not possible because log collection not active")));
 		PG_RETURN_BOOL(false);
 	}
 
@@ -410,7 +410,7 @@ pg_tablespace_databases(PG_FUNCTION_ARGS)
 							 errmsg("could not open directory \"%s\": %m",
 									fctx->location)));
 				ereport(WARNING,
-					  (errmsg("%u is not a tablespace OID", tablespaceOid)));
+						(errmsg("%u is not a tablespace OID", tablespaceOid)));
 			}
 		}
 		funcctx->user_fctx = fctx;
@@ -789,9 +789,9 @@ parse_ident(PG_FUNCTION_ARGS)
 				if (endp == NULL)
 					ereport(ERROR,
 							(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-						   errmsg("string is not a valid identifier: \"%s\"",
-								  text_to_cstring(qualname)),
-						   errdetail("String has unclosed double quotes.")));
+							 errmsg("string is not a valid identifier: \"%s\"",
+									text_to_cstring(qualname)),
+							 errdetail("String has unclosed double quotes.")));
 				if (endp[1] != '"')
 					break;
 				memmove(endp, endp + 1, strlen(endp));
@@ -952,7 +952,7 @@ pg_current_logfile(PG_FUNCTION_ARGS)
 		{
 			/* Uh oh.  No newline found, so file content is corrupted. */
 			elog(ERROR,
-			   "missing newline character in \"%s\"", LOG_METAINFO_DATAFILE);
+				 "missing newline character in \"%s\"", LOG_METAINFO_DATAFILE);
 			break;
 		}
 		*nlpos = '\0';