diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-03-02 23:31:39 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-03-02 23:31:39 -0500 |
| commit | a9d199f6d3b998929cdb8e8aa61e5cd8db9b220f (patch) | |
| tree | 9b82a1bccdedf2b6cd7ebcb64eed8c427ccc3a7f /src/backend/utils/adt/jsonfuncs.c | |
| parent | eb43e851d6b3fa0c4516efcfdf29a183f7717a43 (diff) | |
| download | postgresql-a9d199f6d3b998929cdb8e8aa61e5cd8db9b220f.tar.gz postgresql-a9d199f6d3b998929cdb8e8aa61e5cd8db9b220f.zip | |
Fix json_to_record() bug with nested objects.
A thinko concerning nesting depth caused json_to_record() to produce bogus
output if a field of its input object contained a sub-object with a field
name matching one of the requested output column names. Per bug #13996
from Johann Visagie.
I added a regression test case based on his example, plus parallel tests
for json_to_recordset, jsonb_to_record, jsonb_to_recordset. The latter
three do not exhibit the same bug (which suggests that we may be missing
some opportunities to share code...) but testing seems like a good idea
in any case.
Back-patch to 9.4 where these functions were introduced.
Diffstat (limited to 'src/backend/utils/adt/jsonfuncs.c')
| -rw-r--r-- | src/backend/utils/adt/jsonfuncs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c index 88225aae4dc..363afa76990 100644 --- a/src/backend/utils/adt/jsonfuncs.c +++ b/src/backend/utils/adt/jsonfuncs.c @@ -2438,7 +2438,7 @@ hash_object_field_end(void *state, char *fname, bool isnull) /* * Ignore nested fields. */ - if (_state->lex->lex_level > 2) + if (_state->lex->lex_level > 1) return; /* |