diff options
| author | Alexander Korotkov <akorotkov@postgresql.org> | 2024-11-04 22:43:08 +0200 |
|---|---|---|
| committer | Alexander Korotkov <akorotkov@postgresql.org> | 2024-11-04 22:47:57 +0200 |
| commit | 3a7ae6b3d91e0d011dba1eb8a29e1836c6a33c75 (patch) | |
| tree | 78d10a6e062353c06046ec2a5d82fa94e4897219 /src/backend/tcop/pquery.c | |
| parent | 3293b718a01310c8ce765ace3cb15efcb956a84e (diff) | |
| download | postgresql-3a7ae6b3d91e0d011dba1eb8a29e1836c6a33c75.tar.gz postgresql-3a7ae6b3d91e0d011dba1eb8a29e1836c6a33c75.zip | |
Revert pg_wal_replay_wait() stored procedure
This commit reverts 3c5db1d6b0, and subsequent improvements and fixes
including 8036d73ae3, 867d396ccd, 3ac3ec580c, 0868d7ae70, 85b98b8d5a,
2520226c95, 014f9f34d2, e658038772, e1555645d7, 5035172e4a, 6cfebfe88b,
73da6b8d1b, and e546989a26.
The reason for reverting is a set of remaining issues. Most notably, the
stored procedure appears to need more effort than the utility statement
to turn the backend into a "snapshot-less" state. This makes an approach
to use stored procedures questionable.
Catversion is bumped.
Discussion: https://postgr.es/m/Zyhj2anOPRKtb0xW%40paquier.xyz
Diffstat (limited to 'src/backend/tcop/pquery.c')
| -rw-r--r-- | src/backend/tcop/pquery.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/backend/tcop/pquery.c b/src/backend/tcop/pquery.c index a1f8d03db1e..0c45fcf318f 100644 --- a/src/backend/tcop/pquery.c +++ b/src/backend/tcop/pquery.c @@ -1168,11 +1168,10 @@ PortalRunUtility(Portal portal, PlannedStmt *pstmt, MemoryContextSwitchTo(portal->portalContext); /* - * Some utility commands (e.g., VACUUM, CALL pg_wal_replay_wait()) pop the - * ActiveSnapshot stack from under us, so don't complain if it's now - * empty. Otherwise, our snapshot should be the top one; pop it. Note - * that this could be a different snapshot from the one we made above; see - * EnsurePortalSnapshotExists. + * Some utility commands (e.g., VACUUM) pop the ActiveSnapshot stack from + * under us, so don't complain if it's now empty. Otherwise, our snapshot + * should be the top one; pop it. Note that this could be a different + * snapshot from the one we made above; see EnsurePortalSnapshotExists. */ if (portal->portalSnapshot != NULL && ActiveSnapshotSet()) { |