diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2021-02-15 09:28:08 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2021-02-15 09:28:08 +0200 |
| commit | 54e51dcde03e5c746e8de6243c69fafdc8d0ec7a (patch) | |
| tree | 527e7c66032792e3936b8637dd2e6a903a27b407 /src/backend/tcop/postgres.c | |
| parent | 46d6e5f567906389c31c4fb3a2653da1885c18ee (diff) | |
| download | postgresql-54e51dcde03e5c746e8de6243c69fafdc8d0ec7a.tar.gz postgresql-54e51dcde03e5c746e8de6243c69fafdc8d0ec7a.zip | |
Make ExecGetInsertedCols() and friends more robust and improve comments.
If ExecGetInsertedCols(), ExecGetUpdatedCols() or ExecGetExtraUpdatedCols()
were called with a ResultRelInfo that's not in the range table and isn't a
partition routing target, the functions would dereference a NULL pointer,
relinfo->ri_RootResultRelInfo. Such ResultRelInfos are created when firing
RI triggers in tables that are not modified directly. None of the current
callers of these functions pass such relations, so this isn't a live bug,
but let's make them more robust.
Also update comment in ResultRelInfo; after commit 6214e2b228,
ri_RangeTableIndex is zero for ResultRelInfos created for partition tuple
routing.
Noted by Coverity. Backpatch down to v11, like commit 6214e2b228.
Reviewed-by: Tom Lane, Amit Langote
Diffstat (limited to 'src/backend/tcop/postgres.c')
0 files changed, 0 insertions, 0 deletions