diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2024-02-14 16:34:18 -0600 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2024-02-14 16:34:18 -0600 |
| commit | 28e46325091dfac5c6ab9ea1e047a8d09dbd16e7 (patch) | |
| tree | f48457af83f13b8bba8d600fe33aef1d39373e26 /src/backend/tcop/postgres.c | |
| parent | 3b00fdba9f20b641d5d3c2b781cd435b23540e61 (diff) | |
| download | postgresql-28e46325091dfac5c6ab9ea1e047a8d09dbd16e7.tar.gz postgresql-28e46325091dfac5c6ab9ea1e047a8d09dbd16e7.zip | |
Centralize logic for restoring errno in signal handlers.
Presently, we rely on each individual signal handler to save the
initial value of errno and then restore it before returning if
needed. This is easily forgotten and, if missed, often goes
undetected for a long time.
In commit 3b00fdba9f, we introduced a wrapper signal handler
function that checks whether MyProcPid matches getpid(). This
commit moves the aforementioned errno restoration code from the
individual signal handlers to the new wrapper handler so that we no
longer need to worry about missing it.
Reviewed-by: Andres Freund, Noah Misch
Discussion: https://postgr.es/m/20231121212008.GA3742740%40nathanxps13
Diffstat (limited to 'src/backend/tcop/postgres.c')
| -rw-r--r-- | src/backend/tcop/postgres.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 1a34bd3715f..01b5530f0b1 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -2970,8 +2970,6 @@ quickdie(SIGNAL_ARGS) void die(SIGNAL_ARGS) { - int save_errno = errno; - /* Don't joggle the elbow of proc_exit */ if (!proc_exit_inprogress) { @@ -2993,8 +2991,6 @@ die(SIGNAL_ARGS) */ if (DoingCommandRead && whereToSendOutput != DestRemote) ProcessInterrupts(); - - errno = save_errno; } /* @@ -3004,8 +3000,6 @@ die(SIGNAL_ARGS) void StatementCancelHandler(SIGNAL_ARGS) { - int save_errno = errno; - /* * Don't joggle the elbow of proc_exit */ @@ -3017,8 +3011,6 @@ StatementCancelHandler(SIGNAL_ARGS) /* If we're still here, waken anything waiting on the process latch */ SetLatch(MyLatch); - - errno = save_errno; } /* signal handler for floating point exception */ |