aboutsummaryrefslogtreecommitdiff
path: root/src/backend/tcop/postgres.c
diff options
context:
space:
mode:
authorPeter Eisentraut <peter_e@gmx.net>2017-09-07 12:06:23 -0400
committerPeter Eisentraut <peter_e@gmx.net>2017-09-07 13:56:09 -0400
commit1356f78ea93395c107cbc75dc923e29a0efccd8a (patch)
treea06cc9e40efdf8382692fb79b5b22c3920f93b5f /src/backend/tcop/postgres.c
parent9d71323daca412e6e175595e1e42809fb5e1172d (diff)
downloadpostgresql-1356f78ea93395c107cbc75dc923e29a0efccd8a.tar.gz
postgresql-1356f78ea93395c107cbc75dc923e29a0efccd8a.zip
Reduce excessive dereferencing of function pointers
It is equivalent in ANSI C to write (*funcptr) () and funcptr(). These two styles have been applied inconsistently. After discussion, we'll use the more verbose style for plain function pointer variables, to make it clear that it's a variable, and the shorter style when the function pointer is in a struct (s.func() or s->func()), because then it's clear that it's not a plain function name, and otherwise the excessive punctuation makes some of those invocations hard to read. Discussion: https://www.postgresql.org/message-id/f52c16db-14ed-757d-4b48-7ef360b1631d@2ndquadrant.com
Diffstat (limited to 'src/backend/tcop/postgres.c')
-rw-r--r--src/backend/tcop/postgres.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index c10d891260c..4eb85720a74 100644
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -1114,7 +1114,7 @@ exec_simple_query(const char *query_string)
receiver,
completionTag);
- (*receiver->rDestroy) (receiver);
+ receiver->rDestroy(receiver);
PortalDrop(portal, false);
@@ -2002,7 +2002,7 @@ exec_execute_message(const char *portal_name, long max_rows)
receiver,
completionTag);
- (*receiver->rDestroy) (receiver);
+ receiver->rDestroy(receiver);
if (completed)
{