diff options
| author | Noah Misch <noah@leadboat.com> | 2021-01-30 00:00:27 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2021-01-30 00:00:27 -0800 |
| commit | 8a54e12a38d1545d249f1402f66c8cde2837d97c (patch) | |
| tree | d6b155a68f9e3dc21f1061106320c620eeaeb6ed /src/backend/storage/lmgr/lmgr.c | |
| parent | f77717b2985aa529a185e6988de26b885ca10ddb (diff) | |
| download | postgresql-8a54e12a38d1545d249f1402f66c8cde2837d97c.tar.gz postgresql-8a54e12a38d1545d249f1402f66c8cde2837d97c.zip | |
Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.
In a cluster having used CREATE INDEX CONCURRENTLY while having enabled
prepared transactions, queries that use the resulting index can silently
fail to find rows. Fix this for future CREATE INDEX CONCURRENTLY by
making it wait for prepared transactions like it waits for ordinary
transactions. This expands the VirtualTransactionId structure domain to
admit prepared transactions. It may be necessary to reindex to recover
from past occurrences. Back-patch to 9.5 (all supported versions).
Andrey Borodin, reviewed (in earlier versions) by Tom Lane and Michael
Paquier.
Discussion: https://postgr.es/m/2E712143-97F7-4890-B470-4A35142ABC82@yandex-team.ru
Diffstat (limited to 'src/backend/storage/lmgr/lmgr.c')
| -rw-r--r-- | src/backend/storage/lmgr/lmgr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/storage/lmgr/lmgr.c b/src/backend/storage/lmgr/lmgr.c index 7407672c9d3..5736d03083f 100644 --- a/src/backend/storage/lmgr/lmgr.c +++ b/src/backend/storage/lmgr/lmgr.c @@ -904,8 +904,7 @@ WaitForLockersMultiple(List *locktags, LOCKMODE lockmode, bool progress) /* * Note: GetLockConflicts() never reports our own xid, hence we need not - * check for that. Also, prepared xacts are not reported, which is fine - * since they certainly aren't going to do anything anymore. + * check for that. Also, prepared xacts are reported and awaited. */ /* Finally wait for each such transaction to complete */ |